Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Modify the doc following the v0.5 release, part 2 #1008

Closed
6 tasks done
sylvaincom opened this issue Dec 23, 2024 · 6 comments · Fixed by #1295
Closed
6 tasks done

docs: Modify the doc following the v0.5 release, part 2 #1008

sylvaincom opened this issue Dec 23, 2024 · 6 comments · Fixed by #1295
Assignees
@sylvaincom @MarieSacksick
Labels
documentation Improvements or additions to documentation

Comments

@sylvaincom
Copy link
Contributor

sylvaincom commented Dec 23, 2024 •
edited
Loading

Following #1007

Taking into account comments from @tuscland, @MarieS-WiMLDS and @sylvaincom:
@sylvaincom sylvaincom mentioned this issue Dec 23, 2024
Closed
26 tasks
@MarieSacksick
Copy link
Contributor

MarieSacksick commented Dec 23, 2024 •
edited
Loading

isn't this issue too big?
contributing could be an issue per se (edit: it's actually already one here #882), and about the API, the CVItem signature might be fixed by item visibility switched off + CVReporter might be if we change the signature as asked in this issue #953.
The CLI tab could be an issue per se also.

@sylvaincom sylvaincom self-assigned this Dec 24, 2024
@sylvaincom sylvaincom added documentation Improvements or additions to documentation epic This issue represents major product increments labels Dec 24, 2024
@sylvaincom
Copy link
Contributor Author

Yes, I've added the epic label, we will do sub-issues, and see what I can do with #882 and #953

@sylvaincom sylvaincom mentioned this issue Dec 24, 2024
Open
@MarieSacksick MarieSacksick mentioned this issue Jan 21, 2025
Merged
rouk1 added a commit that referenced this issue Jan 22, 2025
@MarieSacksick @auguste-probabl @rouk1
docs(index): Remove contents at the bottom (#1191)
bc8c43c 
answer part of #1008

---------

Co-authored-by: Auguste Baum <[email protected]>
Co-authored-by: Matt J. <[email protected]>
@MarieSacksick
Copy link
Contributor

I edited the text of the issue to remove everything related to contributing guide, to transform this epic to a regular issue.

@MarieSacksick MarieSacksick removed the epic This issue represents major product increments label Jan 23, 2025
@MarieSacksick MarieSacksick mentioned this issue Jan 23, 2025
Merged
@sylvaincom
Copy link
Contributor Author

Ok thanks, have you created a separate issue for the stuff about the contributing guide?

@MarieSacksick
Copy link
Contributor

it's already listed in #882

@MarieSacksick MarieSacksick mentioned this issue Jan 23, 2025
Merged
@sylvaincom
Copy link
Contributor Author

Perfect

sylvaincom pushed a commit that referenced this issue Jan 23, 2025
@MarieSacksick
docs: Remove skore logo as default thumbnail (#1219)
b4a6bad 
requested in #1008
MarieSacksick added a commit that referenced this issue Jan 28, 2025
@MarieSacksick
docs: Isolate examples (#1213)
cf21491 
fixes #1200  
participates to #1008
@MarieSacksick MarieSacksick self-assigned this Feb 7, 2025
@MarieSacksick MarieSacksick mentioned this issue Feb 7, 2025
Merged
auguste-probabl added a commit that referenced this issue Feb 10, 2025
@MarieSacksick @auguste-probabl
docs: Change colors of links (#1295)
c5d87b3 
Closes #1008

---------

Co-authored-by: Auguste Baum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sylvaincom sylvaincom

@MarieSacksick MarieSacksick

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: Change colors of links probabl-ai/skore
2 participants
@sylvaincom @MarieSacksick