Skip to content

Commit

Permalink
docs: Refine the documentation before the release 0.6.1 (#1204)
Browse files Browse the repository at this point in the history
Various minor stuff

---------

Co-authored-by: MarieS-WiMLDS <[email protected]>
Co-authored-by: Marie <[email protected]>
  • Loading branch information
3 people authored Jan 22, 2025
1 parent 687316d commit c3e28ee
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 6 deletions.
2 changes: 1 addition & 1 deletion examples/getting_started/plot_skore_getting_started.py
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@
# .. seealso::
#
# For more information about the motivation and usage of
# :class:`skore.CrossValidationReport`, see :ref:`example_cross_validate`.
# :class:`skore.CrossValidationReport`, see :ref:`_example_use_case_employee_salaries`.

# %%
# Train-test split with skore
Expand Down
11 changes: 6 additions & 5 deletions examples/model_evaluation/plot_estimator_report.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,10 @@
"""

# %%
#
# TODO: we need to describe the aim of this classification problem.
# First, we load a dataset from skrub. Our goal is to predict if a company paid a physician. The ultimate goal is to
# detect potential conflict of interest when it comes to the actual problem that we want to solve.

# %%
from skrub.datasets import fetch_open_payments

dataset = fetch_open_payments()
Expand Down Expand Up @@ -44,8 +46,8 @@
X_train, X_test, y_train, y_test = train_test_split(df, y, random_state=42)

# %%
# TODO: we have a perfect case to show useful feature of the `train_test_split`
# function from `skore`.
# By the way, notice how skore's :func:`~train_test_split` automatically warns us for a
# class imbalance.
#
# Now, we need to define a predictive model. Hopefully, `skrub` provides a convenient
# function (:func:`skrub.tabular_learner`) when it comes to getting strong baseline
Expand Down Expand Up @@ -224,7 +226,6 @@ def operational_decision_cost(y_true, y_pred, amount):
mask_true_negative = (y_true == neg_label) & (y_pred == neg_label)
mask_false_positive = (y_true == neg_label) & (y_pred == pos_label)
mask_false_negative = (y_true == pos_label) & (y_pred == neg_label)
# FIXME: we need to make sense of the cost sensitive part with the right naming
fraudulent_refuse = mask_true_positive.sum() * 50
fraudulent_accept = -amount[mask_false_negative].sum()
legitimate_refuse = mask_false_positive.sum() * -5
Expand Down
2 changes: 2 additions & 0 deletions examples/technical_details/plot_cache_mechanism.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
"""
.. _example_cache_mechanism:
===============
Cache mechanism
===============
Expand Down
2 changes: 2 additions & 0 deletions examples/use_cases/plot_employee_salaries.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
"""
.. _example_use_case_employee_salaries:
===============================
Simplified experiment reporting
===============================
Expand Down

0 comments on commit c3e28ee

Please sign in to comment.