Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JPA Extensions concerning the search index (https://jira.pvtool.org/b… #3

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

moritz-bayer
Copy link

…rowse/VKO-3070)

Nach besten Wissen und Gewissen in dem Projekt umgesetzt.

Copy link
Member

@stefanseifert stefanseifert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR, lgtm in general.

i've noticed that you've used tabs instead of spaces in all changes to the XML/XSL/XSD files. please convert those two spaces to be in line with the existing code.

Moritz Bayer and others added 2 commits May 10, 2020 16:06
fixed code formatting issues found in code review

search-index was written twice/entity due to a double entry in platform.xml. Also fixed.
regenerate schema code with latest SDK xsd.exe
prepare documentation of new fields
@stefanseifert
Copy link
Member

not all new fields were added to the XSD - i've added them and regenerated the schema code with a current version of xsd.exe.

please update the README file as well - i've already added lines for the new fields, please enter a documentation instead of the "???"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants