This repository has been archived by the owner on Dec 27, 2023. It is now read-only.
Updated the build.py to be compatible with python3 #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This branch has some comments which might help |
| prettyHTML) | ||
| #The if statement is needed to maintain support for both python2 and python3 | ||
| if(type(prettyHTML)!=str): | ||
| #For python2 the type is String and for python3 the type is bytes |
There was a problem hiding this comment.
nit: the whitespace is inconsistent here
opg7371
force-pushed
the
develop-python3-build-file
branch
from
c1d2305 to
c4fca26
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes that i made in the build.py for privly applications is made in from line 70 to 72. The problem was that the type of prettyHTML came out to be different in python2(str) and python3(bytes).So i committed the changes can be seen in line number 78 to 86.The lines changed can be seen in the above commit.