fix: catch errors in async artifact tests

privatenumber · Jun 7, 2024 · d98af76 · d98af76
1 parent ef8a796
commit d98af76
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md
@@ -8,7 +8,7 @@ $ pnpm bench --minifier <minifier> <artifact>
 
 Example:
 ```
-$ pnpm bench --minifier esbuild vue
+$ pnpm bench --minifier esbuild --artifact vue
 ```
 
 ### Benchmark all artifacts & minifiers

diff --git a/packages/artifacts/utils/artifact.ts b/packages/artifacts/utils/artifact.ts
@@ -95,10 +95,10 @@ export class Artifact {
 			code = test.preprocess(code);
 		}
 
-		const codeExport = requireString(code);
 		const privateConsole = blockConsole();
 		try {
-			test.run(codeExport);
+			const codeExport = requireString(code);
+			await test.run(codeExport);
 		} finally {
 			privateConsole.restore();
 		}

diff --git a/packages/artifacts/utils/define-test.ts b/packages/artifacts/utils/define-test.ts
@@ -1,6 +1,6 @@
 export type Test<T = unknown> = {
 	preprocess?: (code: string) => string;
-	run: (exports: T) => void;
+	run: (exports: T) => void | Promise<void>;
 };
 
 export const defineTest = <T>(