Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency ws to v8.17.1 - autoclosed #259

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 9, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
ws 8.14.2 -> 8.17.1 age adoption passing confidence

Release Notes

websockets/ws (ws)

v8.17.1

Compare Source

Bug fixes

A request with a number of headers exceeding the[server.maxHeadersCount][server.maxHeadersCount]
threshold could be used to crash a ws server.

const http = require('http');
const WebSocket = require('ws');

const server = http.createServer();

const wss = new WebSocket.Server({ server });

server.listen(function () {
  const chars = "!#$%&'*+-.0123456789abcdefghijklmnopqrstuvwxyz^_`|~".split('');
  const headers = {};
  let count = 0;

  for (let i = 0; i < chars.length; i++) {
    if (count === 2000) break;

    for (let j = 0; j < chars.length; j++) {
      const key = chars[i] + chars[j];
      headers[key] = 'x';

      if (++count === 2000) break;
    }
  }

  headers.Connection = 'Upgrade';
  headers.Upgrade = 'websocket';
  headers['Sec-WebSocket-Key'] = 'dGhlIHNhbXBsZSBub25jZQ==';
  headers['Sec-WebSocket-Version'] = '13';

  const request = http.request({
    headers: headers,
    host: '127.0.0.1',
    port: server.address().port
  });

  request.end();
});

The vulnerability was reported by Ryan LaPointe in https://github.com/websockets/ws/issues/2230.

In vulnerable versions of ws, the issue can be mitigated in the following ways:

  1. Reduce the maximum allowed length of the request headers using the
    [--max-http-header-size=size][--max-http-header-size=size] and/or the [maxHeaderSize][maxHeaderSize] options so
    that no more headers than the server.maxHeadersCount limit can be sent.
  2. Set server.maxHeadersCount to 0 so that no limit is applied.

v8.17.0

Compare Source

Features

  • The WebSocket constructor now accepts the createConnection option (#​2219).

Other notable changes

  • The default value of the allowSynchronousEvents option has been changed to
    true (#​2221).

This is a breaking change in a patch release. The assumption is that the option
is not widely used.

v8.16.0

Compare Source

Features

  • Added the autoPong option (01ba54e).

v8.15.1

Compare Source

Notable changes

  • The allowMultipleEventsPerMicrotask option has been renamed to
    allowSynchronousEvents (4ed7fe5).

This is a breaking change in a patch release that could have been avoided with
an alias, but the renamed option was added only 3 days ago, so hopefully it
hasn't already been widely used.

v8.15.0

Compare Source

Features

  • Added the allowMultipleEventsPerMicrotask option (93e3552).

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot changed the title Update dependency ws to v8.15.0 Update dependency ws to v8.15.1 Dec 12, 2023
@renovate renovate bot force-pushed the renovate/ws-8.x-lockfile branch from 5fcc89f to 561e232 Compare December 12, 2023 22:43
@renovate renovate bot force-pushed the renovate/ws-8.x-lockfile branch from 561e232 to b2978ee Compare December 26, 2023 19:15
@renovate renovate bot changed the title Update dependency ws to v8.15.1 Update dependency ws to v8.16.0 Dec 26, 2023
@renovate renovate bot changed the title Update dependency ws to v8.16.0 Update dependency ws to v8.17.0 Apr 28, 2024
@renovate renovate bot force-pushed the renovate/ws-8.x-lockfile branch from b2978ee to 4e65e96 Compare April 28, 2024 08:23
@renovate renovate bot changed the title Update dependency ws to v8.17.0 Update dependency ws to v8.17.1 Jun 16, 2024
@renovate renovate bot force-pushed the renovate/ws-8.x-lockfile branch from 4e65e96 to 49902f8 Compare June 16, 2024 15:26
@renovate renovate bot changed the title Update dependency ws to v8.17.1 Update dependency ws to v8.17.1 - autoclosed Jun 18, 2024
@renovate renovate bot closed this Jun 18, 2024
@renovate renovate bot deleted the renovate/ws-8.x-lockfile branch June 18, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants