Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make FindPTLS cmake aware of MBEDTLS flag #1810

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Make FindPTLS cmake aware of MBEDTLS flag #1810

merged 1 commit into from
Dec 18, 2024

Conversation

sav21153
Copy link
Contributor

When building picoquic with mbedtls, we only need "picotls-core" and "picotls-minicrypto" by default.
Make the FindPTLS cmake file aware of the WITH_MBEDTLS flag and include only the required libraries.

huitema
huitema reviewed Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@huitema huitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like these changes -- they should result in greater modularity. But i will wait the results of the test run before approving.

huitema
huitema reviewed Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@huitema huitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Merging, since all tests are green.

@huitema huitema merged commit cb143e5 into private-octopus:master Dec 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huitema huitema huitema left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sav21153 @huitema