Add wake up function to packet loop #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be appreciated if I wrote some documentation around this and the non-threaded socket loop (in a separate branch that can be merged into whatever branch makes sense)? |
|
@notBroman yes, documenting the use of the background thread would be very nice! There is minimal documentation in the header file, but an actual doc would help! |
|
Tests are passing. Merging now, so we get feedback from developers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new API to create a background thread handling the packet loop, to wake up that thread and for example create a new data stream, and to delete the thread.
The first commit simply adds the API, and tests that the old way of running a network loop in line with the app still works.