Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document building picoquic #1611

Merged
merged 11 commits into from
Jan 28, 2024
Merged

Conversation

notBroman
Copy link
Collaborator

resolve #1604

I would appreciate pointers on documentation for how picoquic is supposed to be added/integrated into other projects. I think it would be useful to explain how this project is expected to be used in other projects.

Additionally pointers on what is missing would be appreciated.

Copy link
Collaborator

@huitema huitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments on dependencies

doc/building_picoquic.md Show resolved Hide resolved
doc/building_picoquic.md Show resolved Hide resolved
@notBroman
Copy link
Collaborator Author

I'm ready to merge this branch to main, the file has been linked to the README.md. Of course this will have to be update as development progresses, but I think this is a good start.

Copy link
Collaborator

@huitema huitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this! It is much better to see that as separate file than in the README, and you answer a number of practical questions. I just noted a couple of minor issues, that should be fixed before merging.

doc/building_picoquic.md Outdated Show resolved Hide resolved
doc/building_picoquic.md Show resolved Hide resolved
doc/building_picoquic.md Show resolved Hide resolved
@huitema huitema merged commit b00935a into private-octopus:master Jan 28, 2024
10 checks passed
@notBroman notBroman deleted the document-building branch March 17, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation] Building (and Rebuilding) single targets
2 participants