Verify processing of stream control frames after reset #1598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tests three kinds of events that can involve "Reset Stream", "Max stream data" and "Stop Sending" frames processed after a stream has been reset or otherwise closed:
the ACK may be received after the reset after the stream context
was deleted,
These extra copies shall be ignored with no side effect.
stream was deleted. The stack queries whether the packets needs to
be repeated.
The combination of "ack/extra/need" with three frame types produces
9 possible tests. However, there is no acking processing for
stop sending frames, so we do not implement a test for
"ack of a stop sending frame.
Issue #1597 describes one such event: the stack tries to process the acknowledgement of a "reset stream" frame after the stream has been deleted. This issue is fixed in this PR, along several similar issues detected by the new tests.
Close #1597