This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
insufficient balance error circuit #919
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
crate-bus-mapping
DreamWuGit
changed the title
CPerezz
suggested changes
Dec 1, 2022
| let fn_gen_error_associated_ops = fn_gen_error_state_associated_ops(&exec_error); | ||
| return fn_gen_error_associated_ops(state, geth_steps); | ||
| } | ||
| let fn_gen_error_associated_ops = fn_gen_error_state_associated_ops(&exec_error); |
There was a problem hiding this comment.
Not sure what is done whith this new variable. Which seems to be dropped immediately and does nothing and is not passed anywhere.
There was a problem hiding this comment.
@CPerezz trying to merge this error state into CallOp code as found many of code shares with it especially for gas cost related stuff. if it works, will update spec accordingly.
|
closing this, will open new one for combining into Callop version. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this error execution is different from others(OOG, stack error etc.) we have done, when this error happens, the result was pushed into stack and execution will consume instead of restore to caller's context.
spec PR privacy-scaling-explorations/zkevm-specs#313