Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Add typos tool to CI to automate typo detection #1817

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

goofylfg
Copy link
Contributor

@goofylfg goofylfg commented May 16, 2024

Description

  • advices -> advice but It has appeared many times,Fear of side effects from excessive changes, this PR do not process this typo for now
  • extend-exclude = ["integration-tests/contracts"] is third party lib

Issue Link

close:#1781

@github-actions github-actions bot added crate-bus-mapping Issues related to the bus-mapping workspace member crate-zkevm-circuits Issues related to the zkevm-circuits workspace member CI Issues related to the Continuous Integration mechanisms of the repository. crate-geth-utils Issues related to the geth-utils workspace member labels May 16, 2024
@goofylfg
Copy link
Contributor Author

@ChihChengLiang plz check it, further configuration adjustments may be required

.github/workflows/typos.yml Outdated Show resolved Hide resolved
goofylfg and others added 2 commits May 21, 2024 10:04
@goofylfg
Copy link
Contributor Author

@ChihChengLiang before that have some CI failed, I updated it ,plz check it

Copy link
Collaborator

@ChihChengLiang ChihChengLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @goofylfg for adding the typo check.

@ChihChengLiang ChihChengLiang merged commit fe3a814 into privacy-scaling-explorations:main Jun 3, 2024
16 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI Issues related to the Continuous Integration mechanisms of the repository. crate-bus-mapping Issues related to the bus-mapping workspace member crate-geth-utils Issues related to the geth-utils workspace member crate-zkevm-circuits Issues related to the zkevm-circuits workspace member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants