This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
Streamline the math gadget API #1765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
crate-zkevm-circuits
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We improve the readability by sweeping gadget constructors under the constraint builder.
Issue Link
Quick search and replace
Type of change
Refactor (no updates to logic)
Contents
XGadget::construct(cb, ...)tocb.x(...)Rationale
We keep consumption of the following gadgets unchanged because they are not used frequently enough.