Add solidity verifier of the nova+cyclefold #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaucube
force-pushed
the
feature/solidity-decider-verifier
branch
3 times, most recently
from
4090f28
to
3d2ea64
Compare
arnaucube
force-pushed
the
feature/solidity-decider-verifier
branch
3 times, most recently
from
267e7e1
to
2a44f94
Compare
arnaucube
force-pushed
the
feature/solidity-decider-verifier
branch
from
273c50f
to
9c68076
Compare
…e the calldata from Decider's proof. Missing conversion of the point coordinates into limbs (ark compatible)
…dditive identity in calldata
…cyclefold_decider` to exported objects
…ation, and abstract also the computed setup params (FS & Decider) to compute them only once for all related tests to save test time
…erifier tests without the big circuit
…ametrize limbs params solidity-verifiers: * update solidity limbs logic to last nonnative impl version, and to last u_i.x impl * parametrize limbs params * add light-test feature: replace the '#[cfg(not(test))]' by the 'light-test' feature that by default is not enabled, so when running the github actions we enable the feature 'light-tests', and then we can have a full-test that runs the test without the 'light-tests' flag, but we don't run this big test every time. The choice of a feature is to allow us to control this from other-crates tests (for example for the solidity-verifier separated crate tests, to avoid running the full heavy circuit in the solidity tests)
This is to avoid c depencency for c-kzg which is behind the c-kzg flag and not needed.
arnaucube
force-pushed
the
feature/solidity-decider-verifier
branch
3 times, most recently
from
050f46d
to
fecc1f6
Compare
arnaucube
force-pushed
the
feature/solidity-decider-verifier
branch
from
fecc1f6
to
bc42865
Compare
arnaucube
force-pushed
the
feature/solidity-decider-verifier
branch
from
4d77a59
to
fc84ff0
Compare
|
This PR is now ready for review. |
Merged
…ev flow, also conditionally template the batchCheck related structs and methods from the KZG10 solidity template
arnaucube
force-pushed
the
feature/solidity-decider-verifier
branch
from
dba60e2
to
87d3731
Compare
han0110
reviewed
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
light-testfeature to disable the big number of constraints in the DeciderEthCircuit, feature which is disabled by default, so only when we want to run the 'lightweight' tests we enable it (eg. fast tests locally and for the CI tests)Current version focuses on achieving a working version, future iterations will reduce the gas costs by optimizing the public inputs and the pairing check.
We tested it in Sepolia testnet.