Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Mova folding scheme #161

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

NiDimi
Copy link
Contributor

@NiDimi NiDimi commented Sep 19, 2024

Added code for the Mova folding scheme (as specified in the https://eprint.iacr.org/2024/1220) into the list of the folding-schemes supported.

This PR addresses issue: #133

NiDimi and others added 3 commits September 19, 2024 17:18
@arnaucube arnaucube added the Mova label Sep 19, 2024
@CPerezz
Copy link
Member

CPerezz commented Sep 23, 2024

Aiming for a review next week. Would you be interested @arnaucube on reading the paper + reviewing this as a pair task? @dmpierre you're welcome too ofc!

@arnaucube
Copy link
Collaborator

@CPerezz sure, happy to do a call over it. I must say that this past weekend I went trough the paper to get ready to review this PR, was planning to do a first pass of review this week. But let's coordinate to comment it in a call too.

There is another thing, which may affect this PR, which is the refactor of the Arith traits that @winderica is doing in #162 . Since #162 might be faster to review and unlocks other PRs that @winderica has in the pipeline, might get merged before this PR (#161), and might bring some git conflicts to it. But I think that the changes should not bring much trouble, since would be adapting the Mova code to do a similar thing than what the Nova update is doing in the #162.

@CPerezz
Copy link
Member

CPerezz commented Sep 25, 2024

Agree!!
Let's unblock @winderica and refactor this accordingly then.
That will also give me time to actually read the paper and be able to pair-review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants