add frontend features to reduce the amount of dependencies and compil… #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaucube
force-pushed
the
frontend-features
branch
from
3290fbd to
aa64136
Compare
arnaucube
force-pushed
the
frontend-features
branch
3 times, most recently
from
0043c6a to
c5bab2b
Compare
arnaucube
requested review from
CPerezz and
dmpierre
and removed request for
CPerezz
arnaucube
force-pushed
the
frontend-features
branch
2 times, most recently
from
5bcbfe2 to
1c46ffc
Compare
CPerezz
reviewed
Aug 18, 2024
There was a problem hiding this comment.
I expected Rust to not compile the deps that are not used within the final binary.
2 questions:
-
Have you checked that by creating a new binary and adding sonobe as a dep only using one frontend, if all of them are compiled? I know that Rust has some smart optimizations that work towards this things.
-
Do you have a sense of what improvements in compile time do we get with this PR? Would like to have the improvement noted somewhere.
arnaucube
force-pushed
the
frontend-features
branch
3 times, most recently
from
ecaf6c0 to
f0bb561
Compare
…ation time The reasoning behind this is that compilation time now is too long, in part because dependencies on specific frontends, so if the compilation don't use some frontend it can be turned off by default.
arnaucube
force-pushed
the
frontend-features
branch
from
f0bb561 to
b3e3b3e
Compare
|
Closing this PR as it has been superseded by #168 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ation time
The reasoning behind this is that compilation time now is too long, in part because dependencies on specific frontends, so if the compilation don't use some frontend it can be turned off by default. Also in a normal usage of the lib the dev would choose one of the available frontends, but probably not all of them simultaneously.
resolves #138