Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change primitive/permute visbility to pub #5

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

davidnevadoc
Copy link
Collaborator

Closes #3

@themighty1
Copy link

I had a thought about adding a hazmat crate feature and expose this method as pub only when the feature is enabled. This would prevent any accidental misuse by a casual crate user. I could work on that PR.

But if you guys think that having a feature is an overkill, Im ok to proceed with this approach.

@themighty1
Copy link

Hi, I realized that the current API of the gadget already allows the creation of a in-circuit permutation chip. We do it here https://github.com/tlsnotary/tlsn/blob/ad994f364a9a8ee406789ce975d04b779659232e/crates/components/authdecode/authdecode-core/src/backend/halo2/circuit.rs#L506

With that in mind, there is no need for a hazmat flag to allow the user to compute the permutation outside of the circuit.
Could we merge this?

@davidnevadoc davidnevadoc merged commit 2478c86 into main Dec 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

why is poseidon::primitives::permute private?
2 participants