Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: compilation, docs, CI & clippy #1

Merged
merged 1 commit into from
Feb 16, 2024
Merged

fix: compilation, docs, CI & clippy #1

merged 1 commit into from
Feb 16, 2024
+155 −68

Conversation

adria0
Copy link
Member

@adria0 adria0 commented Feb 16, 2024 •
edited
Loading

This PR fixes some stuff:

  • Adds testing & formatting checks with github CI
  • It renames poseidon to halo2_poseidon, I think that makes more sense to import halo2_poseidon::poseidon::* than poseidon::poseidon::*, also prefixing with halo2_ is somehow ortogonal to our way to define crates in halo2
  • Fixes benches ( removes sinsemilla bench leftover, also )
  • Updates toolchain with the minimum version requiered ( mainly for ahash )
  • Fixes clippy and doc lints

@adria0 adria0 force-pushed the fix/initial_import branch 7 times, most recently from 9f3110f to ecbc6b6 Compare February 16, 2024 11:37
@adria0 adria0 force-pushed the fix/initial_import branch from ecbc6b6 to 97f88e5 Compare February 16, 2024 11:52
@adria0 adria0 requested a review from davidnevadoc February 16, 2024 12:05
davidnevadoc
davidnevadoc approved these changes Feb 16, 2024
View reviewed changes
Copy link
Collaborator

@davidnevadoc davidnevadoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!
Just left a question. LGTM!

src/poseidon/pow5.rs Show resolved Hide resolved
src/poseidon/primitives/p128pow5t3.rs Show resolved Hide resolved
@adria0 adria0 merged commit 764a682 into main Feb 16, 2024
2 checks passed
@davidnevadoc davidnevadoc deleted the fix/initial_import branch February 17, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidnevadoc davidnevadoc davidnevadoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adria0 @davidnevadoc