New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: voice credits per poll #1967

Open

ctrlc03 wants to merge 1 commit into dev from feat/voice-credits-per-poll

Open

feat: voice credits per poll #1967

feat: voice credits per poll

GitHub Advanced Security / Slither succeeded Dec 23, 2024 in 7s

3 new alerts including 1 medium severity security vulnerability

New alerts in code changed by this pull request

Security Alerts:

1 medium
2 low

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 238 in packages/contracts/contracts/MACI.sol

Code scanning / Slither

Contracts that lock Ether Medium

Contract locking ether found:
Contract MACI has payable functions:
- MACI.constructor(IPollFactory,IMessageProcessorFactory,ITallyFactory,SignUpGatekeeper,uint8,uint256[5])
But does not have a function to withdraw the ether

Check notice on line 148 in packages/contracts/contracts/MACI.sol

Code scanning / Slither

Reentrancy vulnerabilities Low

Reentrancy in MACI.signUp(DomainObjs.PubKey,bytes):
External calls:
- signUpGatekeeper.register(msg.sender,_signUpGatekeeperData)
State variables written after the call(s):
- stateRootsOnSignUp.push(stateRoot)

Check notice on line 148 in packages/contracts/contracts/MACI.sol

Code scanning / Slither

Reentrancy vulnerabilities Low

Reentrancy in MACI.signUp(DomainObjs.PubKey,bytes):
External calls:
- signUpGatekeeper.register(msg.sender,_signUpGatekeeperData)
Event emitted after the call(s):
- SignUp(leanIMTData.size - 1,block.timestamp,_pubKey.x,_pubKey.y)