fix(zupass-gatekeeper): event id was stored at the wrong index #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisgarner
requested review from
ctrlc03,
kittybest and
0xmad
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
crisgarner
force-pushed
the
fix/zupassGatekeeper
branch
from
7a7104f
to
207a218
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PCD libraries we use to generate the witness to send the data to the gatekeeper store the event IDs in an array on the 1 and 15 to 37 positions. At the contract level, we were checking the 15 positions, but unless the request is made in a certain way, the 15 value might be invalid. As we are only supporting one event ID for now, there is no need to check the other positions
Additional Notes
Updated the tests also to reflect and tests these changes
Confirmation