Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Redesigned projects built with MACI page #1813

Merged
merged 1 commit into from
Sep 12, 2024
Merged

refactor: Redesigned projects built with MACI page #1813

merged 1 commit into from
Sep 12, 2024

Conversation

MukulKolpe
Copy link
Contributor

Description

Redesigned the MACI projects page to improve user interface and make it easier to update when new projects are added.

Minimal.Anti-Collusion.Infrastructure.MACI._.MACI.-.Google.Chrome.2024-09-06.15-16-54.mp4

Additional Notes

Related issue(s)

Fixes #1613

Confirmation

@vercel Vercel
Copy link

vercel bot commented Sep 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview Sep 12, 2024 3:24am

@MukulKolpe
Copy link
Contributor Author

Hey @ctrlc03, sorry for the delay. Please let me know if any adjustments are needed regarding themes, wording, conventions, etc.

@MukulKolpe MukulKolpe changed the title refactor: Redesigned projects built with MACI refactor: Redesigned projects built with MACI page Sep 7, 2024
ctrlc03
ctrlc03 requested changes Sep 8, 2024
View reviewed changes
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing thank you very much 🚀

Could you please ensure linter checks are passed (you can run locally with pnpm lint:ts:fix) and also it seems like navigation buttons are not displaying correctly in light mode, and the cards and text also

apps/website/src/content/projects.json Outdated Show resolved Hide resolved
apps/website/src/content/projects.json Outdated Show resolved Hide resolved
@kittybest
Copy link
Collaborator

I think the light mode color should be adjusted, other things are perfect! thanks!

image

@MukulKolpe
Copy link
Contributor Author

Thank you @ctrlc03 @kittybest! Please let me know if any other changes are needed.

Projects.built.with.MACI._.MACI.-.Google.Chrome.2024-09-09.22-06-02.mp4

ctrlc03
ctrlc03 approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks so much!! @kittybest I'll leave the final approval to you before merging in case you had more suggestions.

Only one thing please rebase to dev and squash your commits into one

git reset $(git merge-base dev $(git rev-parse --abbrev-ref HEAD))

@ctrlc03
Copy link
Collaborator

ctrlc03 commented Sep 11, 2024

@MukulKolpe seems like you used merge rather than rebase, please squash your commits and rebase to the latest dev :)

kittybest
kittybest approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@kittybest kittybest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks so nice, thanks a lot!

ctrlc03
ctrlc03 reviewed Sep 12, 2024
View reviewed changes
pnpm-lock.yaml Outdated Show resolved Hide resolved
@ctrlc03 ctrlc03 merged commit f730dd7 into privacy-scaling-explorations:dev Sep 12, 2024
22 checks passed
@gitpoap-bot gitpoap-bot
Copy link

gitpoap-bot bot commented Sep 12, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 MACI Contributor:

GitPOAP: 2024 MACI Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@MukulKolpe MukulKolpe deleted the maci-projects branch September 12, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctrlc03 ctrlc03 ctrlc03 approved these changes

@kittybest kittybest kittybest approved these changes

@0xmad 0xmad Awaiting requested review from 0xmad 0xmad is a code owner

@crisgarner crisgarner Awaiting requested review from crisgarner crisgarner is a code owner

Assignees

@MukulKolpe MukulKolpe

Labels
None yet
Projects
MACI team sprint board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

re-design projects built with MACI page
3 participants
@MukulKolpe @kittybest @ctrlc03