Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add result page to devcon round branch #494

Merged
merged 35 commits into from
Nov 25, 2024
Merged

feat: add result page to devcon round branch #494

merged 35 commits into from
Nov 25, 2024

Conversation

kittybest
Copy link
Contributor

@kittybest kittybest commented Nov 20, 2024 •
edited
Loading

Description
Simple display of the tally result at the result page.

Notice
Still need to be e2e tested.

This branch is forked from the feat/devcon-round but rebase main, so it looks like so many commits comparing to the base branch... does anyone have a better way to avoid this? such as merge instead of rebase, or squash commits, or we rebase and force push the feat/devcon-round branch? (but since this feature actually changes lots of parts of the code, that's why I think it should be a separate PR instead of force rebasing it)

@vercel Vercel
Copy link

vercel bot commented Nov 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maci-platform ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 8:05pm

dependabot bot added 8 commits November 21, 2024 02:16
@dependabot @kittybest
chore(deps): bump next-themes from 0.2.1 to 0.4.3
5367839 
Bumps [next-themes](https://github.com/pacocoursey/next-themes) from 0.2.1 to 0.4.3.
- [Release notes](https://github.com/pacocoursey/next-themes/releases)
- [Commits](https://github.com/pacocoursey/next-themes/commits/v0.4.3)

---
updated-dependencies:
- dependency-name: next-themes
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @kittybest
chore(deps): bump tailwindcss from 3.4.7 to 3.4.14
c73a24e 
Bumps [tailwindcss](https://github.com/tailwindlabs/tailwindcss) from 3.4.7 to 3.4.14.
- [Release notes](https://github.com/tailwindlabs/tailwindcss/releases)
- [Changelog](https://github.com/tailwindlabs/tailwindcss/blob/v3.4.14/CHANGELOG.md)
- [Commits](tailwindlabs/tailwindcss@v3.4.7...v3.4.14)

---
updated-dependencies:
- dependency-name: tailwindcss
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @kittybest
chore(deps): bump maci-circuits from 2.3.0 to 2.4.0
1f4b1a1 
Bumps maci-circuits from 2.3.0 to 2.4.0.

---
updated-dependencies:
- dependency-name: maci-circuits
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @kittybest
chore(deps): bump graphql-request from 6.1.0 to 7.1.2
f61afb7 
Bumps [graphql-request](https://github.com/jasonkuhrt/graphql-request) from 6.1.0 to 7.1.2.
- [Release notes](https://github.com/jasonkuhrt/graphql-request/releases)
- [Commits](graffle-js/graffle@6.1.0...7.1.2)

---
updated-dependencies:
- dependency-name: graphql-request
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @kittybest
chore(deps-dev): bump postcss from 8.4.41 to 8.4.47
2a76ebb 
Bumps [postcss](https://github.com/postcss/postcss) from 8.4.41 to 8.4.47.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.4.41...8.4.47)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @kittybest
chore(deps): bump hardhat from 2.22.7 to 2.22.15
7a7a36e 
Bumps [hardhat](https://github.com/nomiclabs/hardhat) from 2.22.7 to 2.22.15.
- [Release notes](https://github.com/nomiclabs/hardhat/releases)
- [Commits](https://github.com/nomiclabs/hardhat/compare/[email protected]@2.22.15)

---
updated-dependencies:
- dependency-name: hardhat
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @kittybest
chore(deps): bump react-hook-form from 7.52.2 to 7.53.1
98dbf62 
Bumps [react-hook-form](https://github.com/react-hook-form/react-hook-form) from 7.52.2 to 7.53.1.
- [Release notes](https://github.com/react-hook-form/react-hook-form/releases)
- [Changelog](https://github.com/react-hook-form/react-hook-form/blob/master/CHANGELOG.md)
- [Commits](react-hook-form/react-hook-form@v7.52.2...v7.53.1)

---
updated-dependencies:
- dependency-name: react-hook-form
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @kittybest
chore(deps): bump @nestjs/websockets from 10.4.4 to 10.4.7
fc2c110 
Bumps [@nestjs/websockets](https://github.com/nestjs/nest/tree/HEAD/packages/websockets) from 10.4.4 to 10.4.7.
- [Release notes](https://github.com/nestjs/nest/releases)
- [Commits](https://github.com/nestjs/nest/commits/v10.4.7/packages/websockets)

---
updated-dependencies:
- dependency-name: "@nestjs/websockets"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
dependabot bot and others added 17 commits November 21, 2024 02:20
@dependabot @kittybest
chore(deps): bump @trpc/client
8aa7aab 
Bumps [@trpc/client](https://github.com/trpc/trpc/tree/HEAD/packages/client) from 11.0.0-next-beta.294 to 11.0.0-rc.608.
- [Release notes](https://github.com/trpc/trpc/releases)
- [Commits](https://github.com/trpc/trpc/commits/HEAD/packages/client)

---
updated-dependencies:
- dependency-name: "@trpc/client"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@0xmad @kittybest
chore: bump trpc packages to 11.0.0-rc.608
17ab160
@0xmad @kittybest
refactor: submit onchain improvements
9df6aef
@kittybest
feat(tally-fetch): added fetch from subgraph
8d55829
@dependabot @kittybest
chore(deps): bump @nivo/line from 0.84.0 to 0.87.0
b6f6832 
Bumps [@nivo/line](https://github.com/plouc/nivo/tree/HEAD/packages/line) from 0.84.0 to 0.87.0.
- [Release notes](https://github.com/plouc/nivo/releases)
- [Changelog](https://github.com/plouc/nivo/blob/master/CHANGELOG.md)
- [Commits](https://github.com/plouc/nivo/commits/v0.87.0/packages/line)

---
updated-dependencies:
- dependency-name: "@nivo/line"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @kittybest
chore(deps): bump @tanstack/react-query from 5.51.21 to 5.59.20
808a734 
Bumps [@tanstack/react-query](https://github.com/TanStack/query/tree/HEAD/packages/react-query) from 5.51.21 to 5.59.20.
- [Release notes](https://github.com/TanStack/query/releases)
- [Commits](https://github.com/TanStack/query/commits/v5.59.20/packages/react-query)

---
updated-dependencies:
- dependency-name: "@tanstack/react-query"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @kittybest
chore(deps): bump @hookform/resolvers from 3.9.0 to 3.9.1
496f3b6 
Bumps [@hookform/resolvers](https://github.com/react-hook-form/resolvers) from 3.9.0 to 3.9.1.
- [Release notes](https://github.com/react-hook-form/resolvers/releases)
- [Commits](react-hook-form/resolvers@v3.9.0...v3.9.1)

---
updated-dependencies:
- dependency-name: "@hookform/resolvers"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @kittybest
chore(deps): bump @radix-ui/react-dropdown-menu from 2.1.1 to 2.1.2
efd90fc 
Bumps [@radix-ui/react-dropdown-menu](https://github.com/radix-ui/primitives) from 2.1.1 to 2.1.2.
- [Changelog](https://github.com/radix-ui/primitives/blob/main/release-process.md)
- [Commits](https://github.com/radix-ui/primitives/commits)

---
updated-dependencies:
- dependency-name: "@radix-ui/react-dropdown-menu"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @kittybest
chore(deps-dev): bump eslint-plugin-import from 2.30.0 to 2.31.0
f4f9aba 
Bumps [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import) from 2.30.0 to 2.31.0.
- [Release notes](https://github.com/import-js/eslint-plugin-import/releases)
- [Changelog](https://github.com/import-js/eslint-plugin-import/blob/main/CHANGELOG.md)
- [Commits](import-js/eslint-plugin-import@v2.30.0...v2.31.0)

---
updated-dependencies:
- dependency-name: eslint-plugin-import
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @kittybest
chore(deps-dev): bump happy-dom from 13.10.1 to 15.11.0
b8e3626 
Bumps [happy-dom](https://github.com/capricorn86/happy-dom) from 13.10.1 to 15.11.0.
- [Release notes](https://github.com/capricorn86/happy-dom/releases)
- [Commits](capricorn86/happy-dom@v13.10.1...v15.11.0)

---
updated-dependencies:
- dependency-name: happy-dom
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @kittybest
chore(deps-dev): bump eslint-config-next from 14.2.4 to 15.0.3
93277bd 
Bumps [eslint-config-next](https://github.com/vercel/next.js/tree/HEAD/packages/eslint-config-next) from 14.2.4 to 15.0.3.
- [Release notes](https://github.com/vercel/next.js/releases)
- [Changelog](https://github.com/vercel/next.js/blob/canary/release.js)
- [Commits](https://github.com/vercel/next.js/commits/v15.0.3/packages/eslint-config-next)

---
updated-dependencies:
- dependency-name: eslint-config-next
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @kittybest
chore(deps): bump lucide-react from 0.316.0 to 0.454.0
5f974a0 
Bumps [lucide-react](https://github.com/lucide-icons/lucide/tree/HEAD/packages/lucide-react) from 0.316.0 to 0.454.0.
- [Release notes](https://github.com/lucide-icons/lucide/releases)
- [Commits](https://github.com/lucide-icons/lucide/commits/0.454.0/packages/lucide-react)

---
updated-dependencies:
- dependency-name: lucide-react
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @kittybest
chore(deps): bump react-number-format from 5.4.0 to 5.4.2
0682a47 
Bumps [react-number-format](https://github.com/s-yadav/react-number-format) from 5.4.0 to 5.4.2.
- [Release notes](https://github.com/s-yadav/react-number-format/releases)
- [Commits](s-yadav/react-number-format@v5.4.0...v5.4.2)

---
updated-dependencies:
- dependency-name: react-number-format
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @kittybest
chore(deps): bump helmet from 7.1.0 to 8.0.0
e72026c 
Bumps [helmet](https://github.com/helmetjs/helmet) from 7.1.0 to 8.0.0.
- [Changelog](https://github.com/helmetjs/helmet/blob/main/CHANGELOG.md)
- [Commits](helmetjs/helmet@v7.1.0...v8.0.0)

---
updated-dependencies:
- dependency-name: helmet
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@0xmad @kittybest
chore: remove caching for synpress runs
b6ba8b2
@kittybest
fix: update the maci-contracts package version
fdf7afc
@dependabot @kittybest
chore(deps-dev): bump @types/papaparse from 5.3.14 to 5.3.15
b074f12 
Bumps [@types/papaparse](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/papaparse) from 5.3.14 to 5.3.15.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/papaparse)

---
updated-dependencies:
- dependency-name: "@types/papaparse"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@kittybest kittybest force-pushed the feat/devcon-round-result-page branch from 1b663a3 to 0a47c5f Compare November 20, 2024 19:34
@kittybest kittybest force-pushed the feat/devcon-round-result-page branch from 0a47c5f to 162246a Compare November 20, 2024 19:40
ctrlc03
ctrlc03 requested changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just two changes to make, tested it and it works

packages/interface/src/config.ts Outdated Show resolved Hide resolved
pnpm-lock.yaml Outdated Show resolved Hide resolved
@kittybest kittybest force-pushed the feat/devcon-round-result-page branch from 162246a to 8a4fd49 Compare November 21, 2024 11:43
@ctrlc03 ctrlc03 self-requested a review November 21, 2024 14:40
ctrlc03
ctrlc03 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

0xmad
0xmad reviewed Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kittybest thanks, just left some comments

package.json Outdated Show resolved Hide resolved
packages/interface/src/contexts/Round.tsx Outdated Show resolved Hide resolved
packages/interface/src/features/results/components/ResultItem.tsx Outdated Show resolved Hide resolved
@kittybest kittybest force-pushed the feat/devcon-round-result-page branch from 8a4fd49 to 42b8bef Compare November 21, 2024 18:25
@kittybest kittybest force-pushed the feat/devcon-round-result-page branch from 42b8bef to 24d6a2f Compare November 21, 2024 19:01
@kittybest kittybest force-pushed the feat/devcon-round-result-page branch from 24d6a2f to 3cd0572 Compare November 22, 2024 17:04
0xmad
0xmad reviewed Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kittybest thanks, just two improvements and I'm good with this PR.
Just fix the types ci job (not sure if e2e can be fixed here).

packages/interface/src/pages/rounds/[pollId]/result/index.tsx Outdated Show resolved Hide resolved
packages/interface/src/utils/types.ts Outdated Show resolved Hide resolved
@kittybest kittybest force-pushed the feat/devcon-round-result-page branch from 3cd0572 to 0423af4 Compare November 22, 2024 19:44
@kittybest
Copy link
Contributor Author

@kittybest thanks, just two improvements and I'm good with this PR. Just fix the types ci job (not sure if e2e can be fixed here).

For the types check, I discussed before with @ctrlc03, that this is a problem that might not be able to be solved now, the error message looks like this:
image

The KernelSmartAccount can not fit in the client type, but the code does work. Seems like they might not be using permissionless package afterward.

@kittybest kittybest force-pushed the feat/devcon-round-result-page branch from 0423af4 to 3bc4910 Compare November 22, 2024 19:59
@ctrlc03 ctrlc03 merged commit 71e4b11 into feat/devcon-round Nov 25, 2024
13 of 15 checks passed
@ctrlc03 ctrlc03 deleted the feat/devcon-round-result-page branch November 25, 2024 14:07
ctrlc03 added a commit that referenced this pull request Nov 26, 2024
@ctrlc03
Merge pull request #494 from privacy-scaling-explorations/feat/devcon…
582dcd4 
…-round-result-page

feat: add result page to devcon round branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmad 0xmad 0xmad left review comments

@ctrlc03 ctrlc03 ctrlc03 approved these changes

@crisgarner crisgarner Awaiting requested review from crisgarner crisgarner is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kittybest @0xmad @ctrlc03