Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix subgroup check in Pluto's G2. #155

Merged
merged 3 commits into from
May 3, 2024
Merged

Fix subgroup check in Pluto's G2. #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd10b80
fix: Pluto G2 torsion_free
davidnevadoc May 2, 2024
7270af0
chore: move new test to test_suite
davidnevadoc May 2, 2024
86c1dc3
fix: cofactor comment
davidnevadoc May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/bn256/curve.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,8 @@ impl G1 {
mod test {
use super::*;
use group::UncompressedEncoding;

crate::curve_testing_suite!(G2, "clear_cofactor");
crate::curve_testing_suite!(G1, G2);
crate::curve_testing_suite!(G1, "hash_to_curve");
crate::curve_testing_suite!(G1, "endo_consistency");
Expand Down
9 changes: 6 additions & 3 deletions src/pluto_eris/curve.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,16 +196,17 @@ impl CofactorGroup for G2 {
}

fn into_subgroup(self) -> CtOption<Self::Subgroup> {
// TODO: Handle the case where the point is already in the subgroup.
CtOption::new(self.clear_cofactor(), 1.into())
}

fn is_torsion_free(&self) -> Choice {
// group order = p
// group order = q
let e: [u8; 56] = [
0x24, 0x00, 0x00, 0x00, 0x00, 0x00, 0x24, 0x00, 0x01, 0x30, 0xe0, 0x00, 0x0d, 0x7f,
0x70, 0xe4, 0xa8, 0x03, 0xca, 0x76, 0xf4, 0x39, 0x26, 0x6f, 0x44, 0x3f, 0x9a, 0x5c,
0xda, 0x8a, 0x6c, 0x7b, 0xe4, 0xa7, 0xa5, 0xfe, 0x8f, 0xad, 0xff, 0xd6, 0xa2, 0xa7,
0xe8, 0xc3, 0x00, 0x06, 0xb9, 0x45, 0x9f, 0xff, 0xfc, 0xd3, 0x00, 0x00, 0x00, 0x01,
0x7a, 0x8a, 0x6c, 0x7b, 0xe4, 0xa7, 0x75, 0xfe, 0x8e, 0x17, 0x7f, 0xd6, 0x9c, 0xa7,
0xe8, 0x5d, 0x60, 0x05, 0x0a, 0xf4, 0x1f, 0xff, 0xfc, 0xd3, 0x00, 0x00, 0x00, 0x01,
];
// self * GROUP_ORDER;
let mut acc = G2::identity();
Expand Down Expand Up @@ -244,6 +245,8 @@ new_curve_impl!(
mod test {
use super::*;
use group::UncompressedEncoding;

crate::curve_testing_suite!(G2, "clear_cofactor");
crate::curve_testing_suite!(G1, Eris, G2);
crate::curve_testing_suite!(G1, Eris, "hash_to_curve");
crate::curve_testing_suite!(G1, Eris, "endo_consistency");
Expand Down
16 changes: 16 additions & 0 deletions src/tests/curve.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,22 @@ macro_rules! curve_testing_suite {
}
};

($($curve: ident),*, "clear_cofactor") => {
#[test]
fn test_cofactor_clearing() {
use rand_core::OsRng;
$(
for _ in 0..50 {
let point = $curve::random(OsRng);
assert!(bool::from(point.is_on_curve()));
use group::cofactor::CofactorGroup;
assert!(bool::from(point.is_torsion_free()));
}

)*
}
};

($($curve: ident),*, "endo_consistency") => {
#[test]
fn test_endo_consistency() {
Expand Down
Loading