-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notify multicore<->WASM compatibility issues #121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just have a small question
@huitseeker @han0110 what about merging #122 instead of this? Feels much more clean. |
That's lovely! Will do the same for Halo2. Also, happy to release both anyways. Such that we have both flavours for now. |
I also tested with privacy-scaling-explorations/halo2#242 and works perfect. Just need some fixes on our side. But nothing wrong with the PR. So I'm tempted to close this and not merge it. |
Solved via #122 |
This PR mainly includes 2 things:
multicore
feature is active while we compile toWASM
.This should close #120 & #116