Add From<bool> for Fields (#171)

feat: add From bool for fields
privacy-scaling-explorations · Jul 25, 2024 · c5c2462 · c5c2462
1 parent 44e142f
commit c5c2462
Show file tree

Hide file tree

Showing 11 changed files with 28 additions and 0 deletions.
diff --git a/src/bls12381/fq.rs b/src/bls12381/fq.rs
@@ -20,6 +20,7 @@ crate::impl_binops_multiplicative!(Fq, Fq);
 crate::field_bits!(Fq);
 crate::serialize_deserialize_primefield!(Fq);
 crate::impl_from_u64!(Fq);
+crate::impl_from_bool!(Fq);
 
 use ff::Field;
 

diff --git a/src/bls12381/fr.rs b/src/bls12381/fr.rs
@@ -20,6 +20,7 @@ crate::impl_binops_multiplicative!(Fr, Fr);
 crate::field_bits!(Fr);
 crate::serialize_deserialize_primefield!(Fr);
 crate::impl_from_u64!(Fr);
+crate::impl_from_bool!(Fr);
 
 #[cfg(test)]
 mod test {

diff --git a/src/bn256/fq.rs b/src/bn256/fq.rs
@@ -21,6 +21,7 @@ crate::impl_binops_multiplicative!(Fq, Fq);
 crate::field_bits!(Fq);
 crate::serialize_deserialize_primefield!(Fq);
 crate::impl_from_u64!(Fq);
+crate::impl_from_bool!(Fq);
 
 use ff::Field;
 const NEGATIVE_ONE: Fq = Fq::ZERO.sub_const(&Fq::ONE);

diff --git a/src/bn256/fr.rs b/src/bn256/fr.rs
@@ -34,6 +34,7 @@ impl From<u64> for Fr {
         }
     }
 }
+crate::impl_from_bool!(Fr);
 
 #[cfg(feature = "bn256-table")]
 #[rustfmt::skip]

diff --git a/src/derive/field/common.rs b/src/derive/field/common.rs
@@ -66,6 +66,24 @@ macro_rules! impl_from_u64 {
     };
 }
 
+#[macro_export]
+macro_rules! impl_from_bool {
+    ($field:ident) => {
+        impl From<bool> for $field {
+            fn from(val: bool) -> $field {
+                let limbs = std::iter::once(u64::from(val))
+                    .chain(std::iter::repeat(0))
+                    .take(Self::NUM_LIMBS)
+                    .collect::<Vec<_>>()
+                    .try_into()
+                    .unwrap();
+
+                $field(limbs) * Self::R2
+            }
+        }
+    };
+}
+
 /// A macro to help define serialization and deserialization for prime field implementations
 /// that use `$field::Repr`` representations. This assumes the concerned type implements PrimeField
 /// (for from_repr, to_repr).

diff --git a/src/pluto_eris/fp.rs b/src/pluto_eris/fp.rs
@@ -21,6 +21,7 @@ crate::impl_binops_multiplicative!(Fp, Fp);
 crate::field_bits!(Fp);
 crate::serialize_deserialize_primefield!(Fp);
 crate::impl_from_u64!(Fp);
+crate::impl_from_bool!(Fp);
 
 impl ExtField for Fp {
     const NON_RESIDUE: Self = Fp::from_raw([

diff --git a/src/pluto_eris/fq.rs b/src/pluto_eris/fq.rs
@@ -20,6 +20,7 @@ crate::impl_binops_multiplicative!(Fq, Fq);
 crate::field_bits!(Fq);
 crate::serialize_deserialize_primefield!(Fq);
 crate::impl_from_u64!(Fq);
+crate::impl_from_bool!(Fq);
 
 #[cfg(test)]
 mod test {

diff --git a/src/secp256k1/fp.rs b/src/secp256k1/fp.rs
@@ -20,6 +20,7 @@ crate::impl_binops_multiplicative!(Fp, Fp);
 crate::field_bits!(Fp);
 crate::serialize_deserialize_primefield!(Fp);
 crate::impl_from_u64!(Fp);
+crate::impl_from_bool!(Fp);
 
 #[cfg(test)]
 mod test {

diff --git a/src/secp256k1/fq.rs b/src/secp256k1/fq.rs
@@ -20,6 +20,7 @@ crate::impl_binops_multiplicative!(Fq, Fq);
 crate::field_bits!(Fq);
 crate::serialize_deserialize_primefield!(Fq);
 crate::impl_from_u64!(Fq);
+crate::impl_from_bool!(Fq);
 
 #[cfg(test)]
 mod test {

diff --git a/src/secp256r1/fp.rs b/src/secp256r1/fp.rs
@@ -20,6 +20,7 @@ crate::impl_binops_multiplicative!(Fp, Fp);
 crate::field_bits!(Fp);
 crate::serialize_deserialize_primefield!(Fp);
 crate::impl_from_u64!(Fp);
+crate::impl_from_bool!(Fp);
 
 #[cfg(test)]
 mod test {

diff --git a/src/secp256r1/fq.rs b/src/secp256r1/fq.rs
@@ -20,6 +20,7 @@ crate::impl_binops_multiplicative!(Fq, Fq);
 crate::field_bits!(Fq);
 crate::serialize_deserialize_primefield!(Fq);
 crate::impl_from_u64!(Fq);
+crate::impl_from_bool!(Fq);
 
 #[cfg(test)]
 mod test {
-Original file line number
+Diff line change
@@ Expand Up / @@ -34,6 +34,7 @@ impl From<u64> for Fr { @@
             }
         }
     }
+    crate::impl_from_bool!(Fr);
     #[cfg(feature = "bn256-table")]
     #[rustfmt::skip]
@@ Expand Down @@