Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved file reading using vtk rectilinear mesh #242

Closed
wants to merge 7 commits into from

Conversation

supriyoumich
Copy link
Contributor

These commits are for external file reading with vtk rectilinear mesh. Currently only unstructured mesh can be read through the input file. However, many problems do not require unstructured mesh. Therefore, rectilinear mesh can reduce the file size and improve the memory usage while reading the files. The default option for file reading is set as unstructured mesh. If you want to read rectilinear file instead, include the following line just below "set Load grain structure" in your input parameter file:
set Load as unstructured grid = false

I compiled the code and it worked for me, hopefully this can be merged with the master.

@david-montiel-t
Copy link
Contributor

Could you instead do the pull request to the development branch so that it goes through the CI check and formatting tests?

Also, I think it would make sense for the flag to be something like

set Input vtk file dataset type = UNSTRUCTURED
or
set Input vtk file dataset type = RECTILINEAR

with the default set to UNSTRUCTURED

This is more in line with other options in the parameters file.

@landinjm landinjm changed the base branch from master to development October 2, 2024 20:16
@supriyoumich supriyoumich reopened this Oct 3, 2024
@supriyoumich
Copy link
Contributor Author

I will be doing a new pull request for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants