Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove tableComponents prop #220

Merged
merged 3 commits into from
Feb 20, 2025
Merged

Conversation

angeloashmore
Copy link
Member

@angeloashmore angeloashmore commented Feb 19, 2025

Resolves: N/A

Description

This PR edits #219 with the following changes:

  • Uses newly exported table field types from @prismicio/client. See fix: export table field types prismic-client#377.
  • Removes the tableComponents prop. It was used in the example but not intended for the final API.
  • Makes the assumption that function-based rich text serializers are not supported.

Important

The new @prismicio/client table types are not published yet, causing tests to fail. @prismicio/client should be updated once prismicio/prismic-client#377 is merged and published.

Checklist

  • A comprehensive Linear ticket, providing sufficient context and details to facilitate the review of the PR, is linked to the PR.
  • If my changes require tests, I added them.
  • If my changes affect backward compatibility, it has been discussed.
  • If my changes require an update to the CONTRIBUTING.md guide, I updated it.

Preview

How to QA 1

Footnotes

  1. Please use these labels when submitting a review:
    ❓ #ask: Ask a question.
    💡 #idea: Suggest an idea.
    ⚠️ #issue: Strongly suggest a change.
    🎉 #nice: Share a compliment.

@levimykel levimykel merged commit 5d43f00 into lg/prismic-table Feb 20, 2025
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants