Lints

.buildkite/docker.sh

@@ -24,6 +24,7 @@ docker run -w /build --network test-net -v $BUILDKITE_BUILD_CHECKOUT_PATH:/build
     -e TEST_MYSQL=mysql://prisma:prisma@test-mysql:3306/prisma \
     -e TEST_PSQL=postgres://prisma:prisma@test-postgres:5432/prisma \
     -e TEST_MSSQL="sqlserver://test-mssql:1433;user=SA;password=$MSSQL_SA_PASSWORD;trustServerCertificate=true" \
+    -e RUSTFLAGS="-Dwarnings" \
     prismagraphql/build:test cargo test --features full,json-1,uuid-0_8,chrono-0_4,tracing-log,serde-support
 
 exit_code=$?

src/ast/column.rs

@@ -39,7 +39,7 @@ where
 }
 
 impl<'a> PartialEq for Column<'a> {
-    fn eq(&self, other: &Column) -> bool {
+    fn eq(&self, other: &Column<'_>) -> bool {
         self.name == other.name && self.table == other.table
     }
 }

src/ast/grouping.rs

@@ -38,14 +38,14 @@ pub trait IntoGroupByDefinition<'a> {
 
 impl<'a> IntoGroupByDefinition<'a> for &'a str {
     fn into_group_by_definition(self) -> GroupByDefinition<'a> {
-        let column: Column = self.into();
+        let column: Column<'_> = self.into();
         column.into()
     }
 }
 
 impl<'a> IntoGroupByDefinition<'a> for (&'a str, &'a str) {
     fn into_group_by_definition(self) -> GroupByDefinition<'a> {
-        let column: Column = self.into();
+        let column: Column<'_> = self.into();
         column.into()
     }
 }

src/ast/index.rs

@@ -33,7 +33,7 @@ impl<'a> IndexDefinition<'a> {
     }
 
     /// True if the index definition contains the given column.
-    pub fn contains(&self, column: &Column) -> bool {
+    pub fn contains(&self, column: &Column<'_>) -> bool {
         match self {
             Self::Single(ref c) if c == column => true,
             Self::Compound(ref cols) if cols.iter().any(|c| c == column) => true,

src/ast/table.rs

@@ -33,7 +33,7 @@ pub struct Table<'a> {
 }
 
 impl<'a> PartialEq for Table<'a> {
-    fn eq(&self, other: &Table) -> bool {
+    fn eq(&self, other: &Table<'_>) -> bool {
         self.typ == other.typ && self.database == other.database
     }
 }
@@ -91,7 +91,7 @@ impl<'a> Table<'a> {
                 Some(dual_col.equals(column.clone()).into())
             };
 
-            Ok::<Option<ConditionTree>, Error>(cond)
+            Ok::<Option<ConditionTree<'_>>, Error>(cond)
         };
 
         for index in self.index_definitions.iter() {

src/ast/union.rs

@@ -8,7 +8,7 @@ pub(crate) enum UnionType {
 }
 
 impl fmt::Display for UnionType {
-    fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         match self {
             UnionType::All => write!(f, "UNION ALL"),
             UnionType::Distinct => write!(f, "UNION"),

src/connector/connection_info.rs

@@ -137,7 +137,7 @@ impl ConnectionInfo {
     }
 
     /// The provided database user name. This will be `None` on SQLite.
-    pub fn username(&self) -> Option<Cow<str>> {
+    pub fn username(&self) -> Option<Cow<'_, str>> {
         match self {
             #[cfg(feature = "postgresql")]
             ConnectionInfo::Postgres(url) => Some(url.username()),

src/connector/mysql.rs

@@ -46,7 +46,7 @@ impl MysqlUrl {
     }
 
     /// The percent-decoded database username.
-    pub fn username(&self) -> Cow<str> {
+    pub fn username(&self) -> Cow<'_, str> {
         match percent_decode(self.url.username().as_bytes()).decode_utf8() {
             Ok(username) => username,
             Err(_) => {
@@ -61,7 +61,7 @@ impl MysqlUrl {
     }
 
     /// The percent-decoded database password.
-    pub fn password(&self) -> Option<Cow<str>> {
+    pub fn password(&self) -> Option<Cow<'_, str>> {
         match self
             .url
             .password()

src/connector/postgres.rs

@@ -154,7 +154,7 @@ impl PostgresUrl {
     }
 
     /// The percent-decoded database username.
-    pub fn username(&self) -> Cow<str> {
+    pub fn username(&self) -> Cow<'_, str> {
         match percent_decode(self.url.username().as_bytes()).decode_utf8() {
             Ok(username) => username,
             Err(_) => {
@@ -191,7 +191,7 @@ impl PostgresUrl {
     }
 
     /// The percent-decoded database password.
-    pub fn password(&self) -> Cow<str> {
+    pub fn password(&self) -> Cow<'_, str> {
         match self
             .url
             .password()
@@ -667,7 +667,7 @@ mod tests {
         assert!(res.is_empty());
     }
 
-    #[allow(unused)]
+    #[allow(dead_code)]
     const TABLE_DEF: &str = r#"
     CREATE TABLE "user"(
         id       int4    PRIMARY KEY     NOT NULL,
@@ -677,13 +677,13 @@ mod tests {
     );
     "#;
 
-    #[allow(unused)]
+    #[allow(dead_code)]
     const CREATE_USER: &str = r#"
     INSERT INTO "user" (id, name, age, salary)
     VALUES (1, 'Joe', 27, 20000.00 );
     "#;
 
-    #[allow(unused)]
+    #[allow(dead_code)]
     const DROP_TABLE: &str = "DROP TABLE IF EXISTS \"user\";";
 
     #[tokio::test]

src/connector/result_set.rs

@@ -54,12 +54,12 @@ impl ResultSet {
     }
 
     /// Returns the first row of the `ResultSet`, or None if the set is empty.
-    pub fn first(&self) -> Option<ResultRowRef> {
+    pub fn first(&self) -> Option<ResultRowRef<'_>> {
         self.get(0)
     }
 
     /// Returns a reference to a row in a given position.
-    pub fn get(&self, index: usize) -> Option<ResultRowRef> {
+    pub fn get(&self, index: usize) -> Option<ResultRowRef<'_>> {
         self.rows.get(index).map(|row| ResultRowRef {
             columns: Arc::clone(&self.columns),
             values: row,

src/connector/result_set/index.rs

@@ -14,13 +14,13 @@ mod private {
 }
 
 impl ValueIndex<ResultRowRef<'_>, Value<'static>> for usize {
-    fn index_into<'v>(self, row: &'v ResultRowRef) -> &'v Value<'static> {
+    fn index_into<'v>(self, row: &'v ResultRowRef<'_>) -> &'v Value<'static> {
         row.at(self).unwrap()
     }
 }
 
 impl ValueIndex<ResultRowRef<'_>, Value<'static>> for &str {
-    fn index_into<'v>(self, row: &'v ResultRowRef) -> &'v Value<'static> {
+    fn index_into<'v>(self, row: &'v ResultRowRef<'_>) -> &'v Value<'static> {
         row.get(self).unwrap()
     }
 }

src/connector/result_set/result_row.rs

@@ -64,7 +64,7 @@ impl ResultRow {
     }
 
     /// Make a referring [ResultRowRef](struct.ResultRowRef.html).
-    pub fn as_ref(&self) -> ResultRowRef {
+    pub fn as_ref(&self) -> ResultRowRef<'_> {
         ResultRowRef {
             columns: Arc::clone(&self.columns),
             values: &self.values,

src/connector/sqlite.rs

@@ -330,7 +330,7 @@ mod tests {
         }
     }
 
-    #[allow(unused)]
+    #[allow(dead_code)]
     const TABLE_DEF: &str = r#"
     CREATE TABLE USER (
         ID INT PRIMARY KEY     NOT NULL,
@@ -340,7 +340,7 @@ mod tests {
     );
     "#;
 
-    #[allow(unused)]
+    #[allow(dead_code)]
     const CREATE_USER: &str = r#"
     INSERT INTO USER (ID,NAME,AGE,SALARY)
     VALUES (1, 'Joe', 27, 20000.00 );

src/connector/sqlite/conversion.rs

@@ -156,7 +156,7 @@ impl<'a> ToColumnNames for SqliteRows<'a> {
 }
 
 impl<'a> ToSql for Value<'a> {
-    fn to_sql(&self) -> Result<ToSqlOutput, RusqlError> {
+    fn to_sql(&self) -> Result<ToSqlOutput<'_>, RusqlError> {
         let value = match self {
             Value::Integer(integer) => integer.map(|i| ToSqlOutput::from(i)),
             Value::Real(d) => d.map(|d| ToSqlOutput::from(d.to_f64().expect("Decimal is not a f64."))),

src/error.rs

@@ -80,7 +80,7 @@ impl Error {
 }
 
 impl fmt::Display for Error {
-    fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         self.kind.fmt(f)
     }
 }

src/lib.rs

@@ -103,6 +103,11 @@
 //! # Ok(())
 //! # }
 //! ```
+
+#![forbid(unsafe_code, future_incompatible, rust_2018_idioms)]
+#![deny(missing_debug_implementations, nonstandard_style)]
+#![warn(missing_docs, unreachable_pub)]
+
 #[macro_use]
 mod macros;
 

src/macros.rs

@@ -116,7 +116,7 @@ macro_rules! aliasable {
                 where
                     T: Into<Cow<'a, str>>,
                 {
-                    let table: Table = self.into();
+                    let table: Table<'_> = self.into();
                     table.alias(alias)
                 }
             }

src/visitor/mysql.rs

@@ -1,7 +1,7 @@
 use crate::{
     ast::*,
-    error::{Error, ErrorKind},
     visitor::{self, Visitor},
+    error::{Error, ErrorKind},
 };
 use std::fmt::{self, Write};
 

src/visitor/sqlite.rs

@@ -1,7 +1,7 @@
 use crate::{
     ast::*,
-    error::{Error, ErrorKind},
     visitor::{self, Visitor},
+    error::{Error, ErrorKind},
 };
 
 use std::fmt::{self, Write};