Never read bigdecimals from SQLite

prisma · May 18, 2021 · 2bee954 · 2bee954
1 parent b25718d
commit 2bee954
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 37 deletions.
diff --git a/db/test.db b/db/test.db
diff --git a/src/connector/sqlite/conversion.rs b/src/connector/sqlite/conversion.rs
@@ -166,12 +166,6 @@ impl<'a> GetRow for SqliteRow<'a> {
                     }
                     _ => Value::integer(i),
                 },
-                #[cfg(feature = "bigdecimal")]
-                ValueRef::Real(f) if column.is_real() => {
-                    use bigdecimal::{BigDecimal, FromPrimitive};
-
-                    Value::numeric(BigDecimal::from_f64(f).unwrap())
-                }
                 ValueRef::Real(f) => Value::double(f),
                 #[cfg(feature = "chrono")]
                 ValueRef::Text(bytes) if column.is_datetime() => {

diff --git a/src/tests/types/sqlite.rs b/src/tests/types/sqlite.rs
@@ -3,7 +3,7 @@ use crate::tests::test_api::sqlite_test_api;
 use crate::tests::test_api::TestApi;
 #[cfg(feature = "chrono")]
 use crate::{ast::*, connector::Queryable};
-#[cfg(feature = "bigdecimal")]
+#[cfg(feature = "chrono")]
 use std::str::FromStr;
 
 test_type!(integer(
@@ -20,36 +20,6 @@ test_type!(integer(
     Value::integer(i64::MAX)
 ));
 
-#[cfg(feature = "bigdecimal")]
-test_type!(real(
-    sqlite,
-    "REAL",
-    Value::Numeric(None),
-    Value::numeric(bigdecimal::BigDecimal::from_str("1.12345").unwrap())
-));
-
-#[cfg(feature = "bigdecimal")]
-test_type!(float_decimal(
-    sqlite,
-    "FLOAT",
-    (Value::Numeric(None), Value::Float(None)),
-    (
-        Value::numeric(bigdecimal::BigDecimal::from_str("3.14").unwrap()),
-        Value::double(3.14)
-    )
-));
-
-#[cfg(feature = "bigdecimal")]
-test_type!(double_decimal(
-    sqlite,
-    "DOUBLE",
-    (Value::Numeric(None), Value::Double(None)),
-    (
-        Value::numeric(bigdecimal::BigDecimal::from_str("3.14").unwrap()),
-        Value::double(3.14)
-    )
-));
-
 test_type!(text(sqlite, "TEXT", Value::Text(None), Value::text("foobar huhuu")));
 
 test_type!(blob(