Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement sqlite schema engine connection with external connector #5133

Merged
merged 2 commits into from
Jan 23, 2025
Merged

feat: implement sqlite schema engine connection with external connector #5133

merged 2 commits into from
Jan 23, 2025

Conversation

jacek-prisma
Copy link
Contributor

@jacek-prisma jacek-prisma commented Jan 20, 2025 •
edited
Loading

Closes ORM-505.

This PR is missing parts that require extending the driver adapter API, but it might be worth merging as is to avoid delaying this until we have the new API.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 20, 2025 •
edited
Loading

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.106MiB 2.106MiB 0.000B
Postgres (gzip) 844.559KiB 844.559KiB 0.000B
Mysql 2.068MiB 2.068MiB 0.000B
Mysql (gzip) 830.605KiB 830.604KiB 1.000B
Sqlite 1.976MiB 1.976MiB 0.000B
Sqlite (gzip) 793.008KiB 793.008KiB 0.000B

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 20, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #5133 will not alter performance

Comparing feat/external-schema-connector-sqlite (414a4dc) with main (bc5b021)

Summary

✅ 11 untouched benchmarks

@jacek-prisma jacek-prisma marked this pull request as ready for review January 22, 2025 16:31
@jacek-prisma jacek-prisma requested a review from a team as a code owner January 22, 2025 16:31
@jacek-prisma jacek-prisma requested review from jkomyno and removed request for a team January 22, 2025 16:31
@jacek-prisma jacek-prisma merged commit acc0b9d into main Jan 23, 2025
366 of 367 checks passed
@jacek-prisma jacek-prisma deleted the feat/external-schema-connector-sqlite branch January 23, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FGoessler FGoessler FGoessler approved these changes

@jkomyno jkomyno Awaiting requested review from jkomyno jkomyno is a code owner automatically assigned from prisma/orm-rust

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacek-prisma @FGoessler