Fix ambiguous imports #4468
Merged
Fix ambiguous imports #4468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelff
requested review from
jkomyno and
Druue
and removed request for
a team
|
@miguelff I'm not sure if this is really needed, because these tests on main are passing https://github.com/prisma/prisma-engines/actions/workflows/query-engine-driver-adapters.yml?query=branch%3Amain, example |
|
Yup, I know it’s passing in main, but it’s causing flakeyness when compiling. Same commit locally compiles, not in CI, it might be depending on the linking order |
Jolg42
approved these changes
Nov 20, 2023
CodSpeed Performance ReportMerging #4468 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #4442