Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(qe): update expected error in SQLite tests with driver adapters #4462

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented Nov 17, 2023

The error message was changed in #4429 but wasn't updated in the tests which resulted in them failing on main.

The error message was changed in
#4429 but wasn't updated
in the tests which resulted in them failing on main.

#4429
@aqrln aqrln requested a review from a team as a code owner November 17, 2023 14:38
@aqrln aqrln requested review from miguelff and jkomyno and removed request for a team November 17, 2023 14:38
@aqrln aqrln added this to the 5.7.0 milestone Nov 17, 2023
@aqrln aqrln self-assigned this Nov 17, 2023
Copy link

codspeed-hq bot commented Nov 17, 2023

CodSpeed Performance Report

Merging #4462 will not alter performance

Comparing test-qe-update-expected-error-in-sqlite-tests-with-driver-adapters (5c3494c) with main (800a9b4)

Summary

✅ 11 untouched benchmarks

@miguelff miguelff merged commit aaed047 into main Nov 17, 2023
28 checks passed
@miguelff miguelff deleted the test-qe-update-expected-error-in-sqlite-tests-with-driver-adapters branch November 17, 2023 15:24
@miguelff
Copy link
Contributor

Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants