Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to Rust 1.74 #4461

Merged
merged 1 commit into from
Nov 17, 2023
Merged

chore: update to Rust 1.74 #4461

merged 1 commit into from
Nov 17, 2023

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented Nov 17, 2023

https://blog.rust-lang.org/2023/11/16/Rust-1.74.0.html

Changes in this commit:

  • Update Nix flake, including nixpkgs and rust-overlay:

    • Rust 1.74
    • Node.js 21.1.0
    • wasm-bindgen 0.2.88
    • etc
  • Bump wasm-bindgen dependency in Cargo.toml to match the new
    version of external wasm-bindgen binary installed on CI via Nix.
    Their versions must always match for the build to succeed.

  • Fix the clippy warnings.

https://blog.rust-lang.org/2023/11/16/Rust-1.74.0.html

Changes in this commit:

* Update Nix flake, including nixpkgs and rust-overlay:

  - Rust 1.74
  - Node.js 21.1.0
  - wasm-bindgen 0.2.88
  - etc

* Bump `wasm-bindgen` dependency in `Cargo.toml` to match the new
  version of external `wasm-bindgen` binary installed on CI via Nix.
  Their versions must always match for the build to succeed.

* Fix the clippy warnings.
@aqrln aqrln requested a review from a team as a code owner November 17, 2023 13:15
@aqrln aqrln requested review from Weakky and Druue and removed request for a team November 17, 2023 13:15
@aqrln aqrln added this to the 5.7.0 milestone Nov 17, 2023
Comment on lines -6 to -7
inputs.rust-overlay.follows = "rust-overlay";
inputs.flake-utils.follows = "flake-utils";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crane doesn't depend on these anymore

Copy link

codspeed-hq bot commented Nov 17, 2023

CodSpeed Performance Report

Merging #4461 will not alter performance

Comparing chore-update-to-rust-1.74 (b7f0918) with main (800a9b4)

Summary

✅ 11 untouched benchmarks

@Jolg42
Copy link
Contributor

Jolg42 commented Nov 17, 2023

@aqrln Technically, that's mostly an update of https://github.com/ipetkov/crane? To which version? It's not obvious to me to find the version in https://github.com/ipetkov/crane/releases

@aqrln
Copy link
Member Author

aqrln commented Nov 17, 2023

@Jolg42

Technically, that's mostly an update of https://github.com/ipetkov/crane?

No, on the Nix side it's primarily an update of nixpkgs and rust-overlay, but crane is updated along the way too.

To which version?

To the latest commit, we are not currently locked to any specific tag.

Copy link
Contributor

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I unlocked the release pipeline in https://buildkite.com/prisma/test-prisma-engines/builds/21627
Could you first check if both the test and release pipelines are passing before merging?

Copy link
Contributor

@miguelff miguelff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not qualified to asess nix changes are correct, but Rust is good.

@aqrln aqrln self-assigned this Nov 17, 2023
@aqrln
Copy link
Member Author

aqrln commented Nov 17, 2023

@Jolg42

Could you first check if both the test and release pipelines are passing before merging?

Sure, but it doesn't really matter, our Docker images used on Buildkite are updated independently and these changes have no influence on them. Nix is only used in the release process of prisma-schema-wasm right now.

It's a problem on its own by the way because they often end up lagging several minor versions behind until we use something that doesn't compile with old Rust anymore and remember to rebuild them, and when rebuilding those images we have no way to automatically test them before rolling them out to be used in CI.

@aqrln aqrln merged commit 49084af into main Nov 17, 2023
51 of 52 checks passed
@aqrln aqrln deleted the chore-update-to-rust-1.74 branch November 17, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants