-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to Rust 1.74 #4461
Conversation
https://blog.rust-lang.org/2023/11/16/Rust-1.74.0.html Changes in this commit: * Update Nix flake, including nixpkgs and rust-overlay: - Rust 1.74 - Node.js 21.1.0 - wasm-bindgen 0.2.88 - etc * Bump `wasm-bindgen` dependency in `Cargo.toml` to match the new version of external `wasm-bindgen` binary installed on CI via Nix. Their versions must always match for the build to succeed. * Fix the clippy warnings.
inputs.rust-overlay.follows = "rust-overlay"; | ||
inputs.flake-utils.follows = "flake-utils"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
crane
doesn't depend on these anymore
CodSpeed Performance ReportMerging #4461 will not alter performanceComparing Summary
|
@aqrln Technically, that's mostly an update of https://github.com/ipetkov/crane? To which version? It's not obvious to me to find the version in https://github.com/ipetkov/crane/releases |
No, on the Nix side it's primarily an update of nixpkgs and rust-overlay, but crane is updated along the way too.
To the latest commit, we are not currently locked to any specific tag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I unlocked the release pipeline in https://buildkite.com/prisma/test-prisma-engines/builds/21627
Could you first check if both the test and release pipelines are passing before merging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not qualified to asess nix changes are correct, but Rust is good.
Sure, but it doesn't really matter, our Docker images used on Buildkite are updated independently and these changes have no influence on them. Nix is only used in the release process of It's a problem on its own by the way because they often end up lagging several minor versions behind until we use something that doesn't compile with old Rust anymore and remember to rebuild them, and when rebuilding those images we have no way to automatically test them before rolling them out to be used in CI. |
https://blog.rust-lang.org/2023/11/16/Rust-1.74.0.html
Changes in this commit:
Update Nix flake, including nixpkgs and rust-overlay:
Bump
wasm-bindgen
dependency inCargo.toml
to match the newversion of external
wasm-bindgen
binary installed on CI via Nix.Their versions must always match for the build to succeed.
Fix the clippy warnings.