feat: add support for nested transaction rollbacks via savepoints in sql #4405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #4405 will improve performances by 5.78%Comparing Summary
Benchmarks breakdown
|
This is my first OSS contribution for a Rust project, so I'm sure I've made some stupid mistakes, but I think it should mostly work :) This change adds a mutable depth counter, that can track how many levels deep a transaction is, and uses savepoints to implement correct rollback behaviour. Previously, once a nested transaction was complete, it would be saved with `COMMIT`, meaning that even if the outer transaction was rolled back, the operations in the inner transaction would persist. With this change, if the outer transaction gets rolled back, then all inner transactions will also be rolled back. Different flavours of SQL servers have different syntax for handling savepoints, so I've had to add new methods to the `Queryable` trait for getting the commit and rollback statements. These are both parameterized by the current depth. I've additionally had to modify the `begin_statement` method to accept a depth parameter, as it will need to conditionally create a savepoint. Signed-off-by: Lucian Buzzo <[email protected]>
Signed-off-by: Lucian Buzzo <[email protected]>
Signed-off-by: Lucian Buzzo <[email protected]>
Signed-off-by: Lucian Buzzo <[email protected]>
This allows an existing transaction ID to be used when starting a new transaction, useful for nested transactions. Signed-off-by: Lucian Buzzo <[email protected]>
Jolg42
force-pushed
the
integration/sql-nested-transactions
branch
from
5a0f60f to
4c24703
Compare
|
@Jolg42 Dumb question: how do we now update prisma/prisma#21678 to use this buildkite release? |
|
@LucianBuzzo |
|
Indeed, like Jan said, I can see it popped up as an automated PR here prisma/prisma#21852 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #4375 but in our repo to trigger Buildkite