Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new guide on using Prisma ORM in docker #6612

Merged
merged 17 commits into from
Jan 29, 2025
Merged

feat: add new guide on using Prisma ORM in docker #6612

merged 17 commits into from
Jan 29, 2025

Conversation

ankur-arch
Copy link
Contributor

@ankur-arch ankur-arch commented Jan 22, 2025

Resolves #4365

Copy link
Contributor

Dangerous URL check

No absolute URLs to prisma.io/docs found.
No local URLs found.

@ankur-arch ankur-arch marked this pull request as draft January 22, 2025 10:37
Copy link
Contributor

Redirect check

This PR probably requires the following redirects to be added to static/_redirects:

  • This PR does not change any pages in a way that would require a redirect.

Copy link

cloudflare-workers-and-pages bot commented Jan 22, 2025

Deploying docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 219eca6
Status: ✅  Deploy successful!
Preview URL: https://60679b07.docs-51g.pages.dev
Branch Preview URL: https://da-2109.docs-51g.pages.dev

View logs

Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 20%, saving 61.92 KB.

Filename Before After Improvement Visual comparison
static/img/guides/prisma-orm-docker.png 310.26 KB 248.33 KB -20.0% View diff

171 images did not require optimisation.

@ankur-arch ankur-arch self-assigned this Jan 24, 2025
@ankur-arch ankur-arch marked this pull request as ready for review January 24, 2025 23:14
@ankur-arch ankur-arch requested a review from jharrell January 24, 2025 23:14
Copy link
Member

@nikolasburk nikolasburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice guide! I only had a few small suggestions. two things that I saw across the entire guide:

  • for some reason I needed to run docker compose ... instead of docker-compose. is that expected?
  • I would add a period after the numbers, e.g. 1.1. instead of 1.1. you did this for the 3.1. options already but iot would be nice to have it everywhere.

Copy link
Member

@nikolasburk nikolasburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥

@ankur-arch ankur-arch merged commit a42dbfd into main Jan 29, 2025
10 of 12 checks passed
@ankur-arch ankur-arch deleted the DA-2109 branch January 29, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Serverless: OS Support Initiative): Document how to use Prisma with Docker / Linux Distros
2 participants