Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update posthog plugin #6388

Merged
merged 3 commits into from
Nov 5, 2024
Merged

feat: Update posthog plugin #6388

merged 3 commits into from
Nov 5, 2024

Conversation

carlagn
Copy link
Contributor

@carlagn carlagn commented Nov 5, 2024

Fixes #WEB-746

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Dangerous URL check

No absolute URLs to prisma.io/docs found.
No local URLs found.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Redirect check

This PR probably requires the following redirects to be added to static/_redirects:

  • This PR does not change any pages in a way that would require a redirect.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Nov 5, 2024 •
edited
Loading

Deploying docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 05cf6d0
Status: ✅  Deploy successful!
Preview URL: https://8314d3f3.docs-51g.pages.dev
Branch Preview URL: https://feat-web-746-update-posthog.docs-51g.pages.dev

View logs

SergeySatunin
SergeySatunin approved these changes Nov 5, 2024
View reviewed changes
Copy link

@SergeySatunin SergeySatunin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posthog doesn't trigger pageview events for table of contents links with these changes.

@carlagn carlagn merged commit 51058d2 into main Nov 5, 2024
7 checks passed
@carlagn carlagn deleted the feat/WEB-746-update-posthog-plugin branch November 5, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur-arch ankur-arch ankur-arch approved these changes

@SergeySatunin SergeySatunin SergeySatunin approved these changes

@jharrell jharrell Awaiting requested review from jharrell

@mhessdev mhessdev Awaiting requested review from mhessdev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlagn @SergeySatunin @ankur-arch