Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filenames to TypeScript files in TypedSQL docs #6236

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

karlhorky
Copy link
Contributor

First of all, thanks for Prisma and TypedSQL! Really great projects and tools.

The TypedSQL docs page contains some ambiguous code blocks.

Eg. this code block looks like you can write TypeScript directly in the SQL file:

Screenshot 2024-09-05 at 14 41 32

Adding filenames for the TypeScript code blocks should help.

@jharrell
Copy link
Member

Wow, thank you for noticing that! It looks like we have a visual issue where if two codeblocks are right next to one another, they can appear as one code block. This is a good fix, but we should also resolve the visual issue.

Thank you very much for your contribution!

@jharrell jharrell merged commit 56ebabc into prisma:main Sep 13, 2024
3 of 6 checks passed
@karlhorky
Copy link
Contributor Author

@jharrell no problem, glad to help! Thanks for the review and merge!

And yeah, agreed that the underlying problem should probably be resolved as well.

If zooming in, there is a slight rounded corner and (very subtle) shadow on the edge of the code block - but agreed this is probably not enough of a visual signal that there is a new separate code block starting:

Screenshot 2024-09-13 at 17 58 52

@karlhorky karlhorky deleted the patch-1 branch September 13, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants