Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docs for Pulse Delivery Guarantees #6015

Merged
merged 51 commits into from
May 28, 2024
Merged

add docs for Pulse Delivery Guarantees #6015

merged 51 commits into from
May 28, 2024

Conversation

nikolasburk
Copy link
Member

No description provided.

Copy link
Contributor

Absolute URL check

No absolute URLs to prisma.io/docs found.

Copy link
Contributor

Redirect check

This PR probably requires the following redirects to be added to static/_redirects:

/pulse/concepts /docs/##( TODO: Path of page that replaces deleted page )##

Copy link

cloudflare-workers-and-pages bot commented May 20, 2024

Deploying docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 371065b
Status: ✅  Deploy successful!
Preview URL: https://68431642.docs-51g.pages.dev
Branch Preview URL: https://feat-pulse-dgs.docs-51g.pages.dev

View logs

content/400-pulse/100-what-is-pulse.mdx Outdated Show resolved Hide resolved
content/400-pulse/100-what-is-pulse.mdx Outdated Show resolved Hide resolved
content/400-pulse/200-getting-started.mdx Outdated Show resolved Hide resolved
content/400-pulse/200-getting-started.mdx Outdated Show resolved Hide resolved
content/400-pulse/200-getting-started.mdx Outdated Show resolved Hide resolved
content/400-pulse/300-database-events.mdx Outdated Show resolved Hide resolved
content/400-pulse/300-database-events.mdx Outdated Show resolved Hide resolved
@@ -1,15 +1,13 @@
---
title: 'API reference'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you ran prettier (or something similar) on this file. Could we remove those changes? (sorry)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for my own understanding: What's the issue with that? Just consistency with other files?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally think double-quotes are preferable in frontmatter because they allow usage of single quotes in the frontmatter content

content/400-pulse/600-faq.mdx Outdated Show resolved Hide resolved
static/_redirects Outdated Show resolved Hide resolved
content/400-pulse/100-what-is-pulse.mdx Outdated Show resolved Hide resolved
content/400-pulse/100-what-is-pulse.mdx Outdated Show resolved Hide resolved
content/400-pulse/200-getting-started.mdx Outdated Show resolved Hide resolved
content/400-pulse/200-getting-started.mdx Outdated Show resolved Hide resolved
content/400-pulse/300-database-events.mdx Outdated Show resolved Hide resolved
content/400-pulse/300-database-events.mdx Outdated Show resolved Hide resolved
content/400-pulse/400-api-reference.mdx Outdated Show resolved Hide resolved
content/400-pulse/400-api-reference.mdx Show resolved Hide resolved
content/400-pulse/400-api-reference.mdx Outdated Show resolved Hide resolved
content/400-pulse/600-faq.mdx Outdated Show resolved Hide resolved
nikolasburk and others added 23 commits May 24, 2024 12:15
content/400-pulse/100-what-is-pulse.mdx Outdated Show resolved Hide resolved
@nikolasburk nikolasburk merged commit e8b4102 into main May 28, 2024
8 of 11 checks passed
@nikolasburk nikolasburk deleted the feat/pulse-dgs branch May 28, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants