handle error and include some traits #4
Conversation
| @@ -69,7 +69,16 @@ impl Behavior<()> for Deployer { | |||
| pool, | |||
| ); | |||
|
|
|||
| messager.send(To::All, serde_json::to_string(&deployment_data)?).await; | |||
There was a problem hiding this comment.
Could just ? here to save LOC as it is effectively the same thing
There was a problem hiding this comment.
yeah, prefer using this ? tbh, mistake on my path
| @@ -12,5 +12,5 @@ async fn main() { | |||
| let deployer = Agent::builder("deployer").with_behavior(Deployer); | |||
|
|
|||
| world.add_agent(deployer); | |||
| world.run().await; | |||
| let _ = world.run().await; | |||
There was a problem hiding this comment.
A very good linter: https://doc.rust-lang.org/stable/clippy/usage.html
|
@Autoparallel i don't understand some part, why do we have to manually implement debug and clone when we can just use derive in bitmath.rs |
The bindings are codegen-ed by ethers-rs. |
probably why it's getting depreceated |
There was a problem hiding this comment.
Let's not change any bindings files as they are quite finnicky and autogenned
There was a problem hiding this comment.
@Autoparallel yep, will close this
| @@ -12,5 +12,5 @@ async fn main() { | |||
| let deployer = Agent::builder("deployer").with_behavior(Deployer); | |||
|
|
|||
| world.add_agent(deployer); | |||
| world.run().await; | |||
| let _ = world.run().await; | |||
There was a problem hiding this comment.
A very good linter: https://doc.rust-lang.org/stable/clippy/usage.html
| let _ = messager | ||
| .send(To::All, serde_json::to_string(&deployment_data)?) | ||
| .await; |
There was a problem hiding this comment.
| let _ = messager | |
| .send(To::All, serde_json::to_string(&deployment_data)?) | |
| .await; | |
| messager | |
| .send(To::All, serde_json::to_string(&deployment_data)?) | |
| .await?; |
There was a problem hiding this comment.
Usually prefer to use the ? and not even catch the errors manually unless I need to do something with them. https://doc.rust-lang.org/rust-by-example/std/result/question_mark.html
The linter gets mad when you do messager.send(_).await as the Result<_,_> type is tagged by clippy as must_use. By doing let _ = messager.send(_).await what happens is that the Result is actually immediately dropped and we won't know if it is Ok or Err!
handled error gracefully
included some necessary traits fro end users