Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pool deployer and token deployment -> token_admin #16

Merged
merged 5 commits into from
Feb 23, 2024
Merged

Pool deployer and token deployment -> token_admin #16

merged 5 commits into from
Feb 23, 2024

Conversation

ts0yu
Copy link
Collaborator

@ts0yu ts0yu commented Feb 23, 2024

No description provided.

@ts0yu ts0yu requested review from Autoparallel and N0xMare and removed request for Autoparallel and N0xMare February 23, 2024 20:07
@ts0yu ts0yu marked this pull request as draft February 23, 2024 20:08
@ts0yu ts0yu changed the title WIP DO NOT MERGE: Pool deployer and token deployment -> token_admin Pool deployer and token deployment -> token_admin Feb 23, 2024
@ts0yu ts0yu marked this pull request as ready for review February 23, 2024 20:45
@ts0yu ts0yu added the ⚡️ feature New feature or request label Feb 23, 2024
Autoparallel
Autoparallel previously requested changes Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@Autoparallel Autoparallel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, but can we get some tests to make sure this is all working together as planned? Hard to move forward if we don't know what's working.

N0xMare
N0xMare approved these changes Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@N0xMare N0xMare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to merge :)

@ts0yu ts0yu merged commit d1b9ad9 into main Feb 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N0xMare N0xMare N0xMare approved these changes

@Autoparallel Autoparallel Autoparallel left review comments

Assignees
No one assigned
Labels
⚡️ feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ts0yu @Autoparallel @N0xMare