fix: g3m fee logic #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Autoparallel
force-pushed
the
fix/g3m-fee
branch
from
45bc289
to
27286d2
Compare
|
@kinrezC the tests now fail in the optimal arbs :( We gotta redo this math haha |
commit 8ee49e0 Merge: bf13638 36a449e Author: Clément Lakhal <[email protected]> Date: Thu Feb 22 15:03:01 2024 +0400 Merge pull request #10 from primitivefinance/feat/strategy-notebooks-desmos feat: refactor + notebooks + strategy READMEs commit 36a449e Author: clemlak <[email protected]> Date: Thu Feb 22 14:47:38 2024 +0400 chore: fix errors due to outdated imports and names commit 8865c35 Author: Colin Roberts <[email protected]> Date: Wed Feb 21 21:01:23 2024 -0700 Update README.md commit 1cf2670 Author: Colin Roberts <[email protected]> Date: Wed Feb 21 15:52:13 2024 -0700 edit: LogNormal and GeometricMean commit b22dbf6 Author: Colin Roberts <[email protected]> Date: Wed Feb 21 15:15:11 2024 -0700 edit: GeometricMean README commit 236a526 Author: Colin Roberts <[email protected]> Date: Wed Feb 21 14:35:47 2024 -0700 Squashed commit of the following: commit bf13638 Author: Colin Roberts <[email protected]> Date: Wed Feb 21 09:28:39 2024 -0700 feat: DFMM kit Rust crate (#5) * feat: dfmm kit * feat: `Pool` struct and impls * feat: README.md * fix: the swap_data --------- Co-authored-by: Waylon Jepsen <[email protected]> commit bf13638 Author: Colin Roberts <[email protected]> Date: Wed Feb 21 09:28:39 2024 -0700 feat: DFMM kit Rust crate (#5) * feat: dfmm kit * feat: `Pool` struct and impls * feat: README.md * fix: the swap_data --------- Co-authored-by: Waylon Jepsen <[email protected]> commit 565b3ca Author: Colin Roberts <[email protected]> Date: Wed Feb 21 08:26:05 2024 -0700 add notebooks and READMEs commit 5ea1a16 Author: Colin Roberts <[email protected]> Date: Wed Feb 21 08:12:49 2024 -0700 refactor: rename G3M -> GeometricMean commit d966e37 Author: Colin Roberts <[email protected]> Date: Wed Feb 21 08:05:02 2024 -0700 refactor: layout commit 76d8c54 Author: Clément Lakhal <[email protected]> Date: Wed Feb 21 18:32:17 2024 +0400 chore: repo org (#7) * chore: add .env to .gitignore * chore: add env.example * build: enable via-ir in Foundry settings * chore: update README
Autoparallel
commented
Mar 13, 2024
| dfmm.swap(poolId, swapData); | ||
| } | ||
|
|
||
| function test_g3m_swap_x_in_deep() public deep { |
There was a problem hiding this comment.
@kinrezC look here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working here to fix the fee accounting for GeometricMean
TODO:
Closes #3