Ensure full_width:
option is respected by the auto_complete input
#3205
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This PR passes the
full_width:
option through to the auto complete component from the form input. TheAutoComplete
component accepts thefull_width:
option, but that's also a shared/common option that all form controls accept. TheInput
base class deletes it from the hash ofsystem_arguments
, meaning it does not then get passed to theAutoComplete
component. I believefull_width:
is the only attribute with this problem, as other shared attributes are not deleted fromsystem_arguments
.Screenshots
The
AutoComplete
component uses the same CSS classes for the<input>
element as the rest of the forms framework. Take a look at the text field input or theTextField
component to preview the effect of thefull_width:
option.Integration
No changes necessary in production. I should note however that
full_width: true
is the default for all form inputs, which now includesAutoComplete
. TheAutoComplete
component itself however defaults tofull_width: false
, meaning this PR will effectively change the default fromfalse
totrue
. Dotcom does not appear to use the auto complete input at all, so changing the default should have no practical effect in production.List the issues that this change affects.
Fixes #3195
Risk Assessment
Accessibility
Merge checklist
- [ ] Added/updated documentation- [ ] Added/updated previews (Lookbook)Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.