Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eager load forms code #3099

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Eager load forms code #3099

merged 2 commits into from
Sep 23, 2024

Conversation

camertron
Copy link
Contributor

What are you trying to accomplish?

This PR moves the forms framework files from lib/primer/forms to app/lib/primer/forms to take advantage of Rails eager loading capabilities in prod environments.

Integration

No changes necessary in production.

List the issues that this change affects.

Closes #3084

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

@camertron camertron added the skip changeset Pull requests that don't change the library output label Sep 17, 2024
Copy link

changeset-bot bot commented Sep 17, 2024

⚠️ No Changeset found

Latest commit: be92278

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@camertron camertron marked this pull request as ready for review September 18, 2024 17:05
@camertron camertron requested a review from a team as a code owner September 18, 2024 17:05
@camertron camertron requested review from broccolinisoup and jonrohan and removed request for broccolinisoup September 18, 2024 17:05
@camertron camertron merged commit 5533045 into main Sep 23, 2024
37 checks passed
@camertron camertron deleted the eager_load_forms branch September 23, 2024 23:03
@jhawthorn
Copy link

Thanks for fixing this!

@keithamus keithamus mentioned this pull request Oct 1, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Pull requests that don't change the library output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forms are not eager loaded
3 participants