Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the default space between form elements #3087

Closed
wants to merge 1 commit into from
Closed

Increase the default space between form elements #3087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tricky-foxes-train.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/view-components': patch
---

Increase space between form elements
2 changes: 1 addition & 1 deletion app/components/primer/alpha/text_field.pcss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
.FormControl-spacingWrapper {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camertron - is this class used for spacing between form control children (e.g.: label, input, caption) or is this class intended to add spacing between a set of form controls?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It adds spacing between individual form controls, not between constituent form control items like label, input, etc.

display: flex;
flex-direction: column;
row-gap: 0.5rem;
row-gap: var(--stack-gap-normal);
}

.FormControl-horizontalGroup {
Expand Down
Loading