Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup animations in dialog #2515

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Fixup animations in dialog #2515

merged 1 commit into from
Jan 18, 2024

Conversation

keithamus
Copy link
Member

@keithamus keithamus commented Jan 18, 2024

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

When integrating #2492 which is the big change to <dialog> I noticed that #2496 regressed some of the animations (I had not initially spotted this as I use prefers-reduced-motion and I forgot to toggle it off during #2496 during development but I remembered when integrating into dotcom).

This PR reintroduces the animations. I've marked skip changeset as this should be rolled up into the #2496 changeset.

Integration

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Anything you want to highlight for special attention from reviewers?

Accessibility

  • Fixes axe scan violation - This change fixes an existing axe scan violation.
  • No new axe scan violation - This change does not introduce any new axe scan violations.
  • New axe violation - This change introduces a new axe scan violation. Please describe why the violation cannot be resolved below.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@keithamus keithamus requested a review from a team as a code owner January 18, 2024 14:25
@keithamus keithamus requested review from a team, rezrah and camertron January 18, 2024 14:25
Copy link

changeset-bot bot commented Jan 18, 2024

⚠️ No Changeset found

Latest commit: d85b9cf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@keithamus keithamus force-pushed the fixup-animations-in-dialog branch from d7e4ae0 to d85b9cf Compare January 18, 2024 14:26
@keithamus keithamus added the skip changeset Pull requests that don't change the library output label Jan 18, 2024
@keithamus keithamus merged commit 6cd97cc into main Jan 18, 2024
32 of 33 checks passed
@keithamus keithamus deleted the fixup-animations-in-dialog branch January 18, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Pull requests that don't change the library output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants