Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redirects for /react sub-site #400

Merged
merged 4 commits into from
Aug 13, 2024
Merged

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Aug 9, 2024

First part of https://github.com/github/primer/issues/3334

From To
/react /
/react/getting-started /guides/react
/react/theming /guides/react/theming
/react/theme-reference /guides/react/theme-reference
/react/linting /guides/react/linting
/react/system-props /guides/react/system-props
/react/core-concepts /guides/react/core-concepts
/react/philosophy /guides/react/philosophy
/react/overriding-styles /guides/react/overriding-styles
/react/status /guides/status
/react/hooks/useSafeTimeout /guides/react/hooks/use-safe-timeout

@joshblack joshblack requested a review from camertron August 9, 2024 17:21
@joshblack joshblack marked this pull request as ready for review August 9, 2024 17:21
Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Would recommend testing this in staging first, but otherwise 🚀

redirects.json Outdated Show resolved Hide resolved
@joshblack
Copy link
Member Author

Testing the redirect links above on the staging site seem to work as expected! Tested a couple of the other redirects, as well, to verify they still worked. Will merge this in and monitor things 🤞

@joshblack joshblack merged commit eed8873 into main Aug 13, 2024
6 checks passed
@joshblack joshblack deleted the feat/add-redirects-for-slash-react branch August 13, 2024 14:57
joshblack added a commit that referenced this pull request Aug 13, 2024
joshblack added a commit that referenced this pull request Aug 13, 2024
@joshblack joshblack restored the feat/add-redirects-for-slash-react branch August 13, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants