Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(dependabot): update config to support workspaces #660

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

joshblack
Copy link
Member

With the current dependabot config, sub-packages of the workspaces would not update the lockfile for the overall workspace and would need to be manually updated by reviewers. In this PR, the sub-paths for npm are removed from the dependabot config so that all workspaces are checked and the updates are made accordingly in package-lock.json

@joshblack joshblack requested review from a team and langermank October 10, 2023 20:26
@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2023

⚠️ No Changeset found

Latest commit: 95582da

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the current dependabot config, sub-packages of the workspaces would not update the lockfile for the overall workspace

Thanks for the context!

And thanks for pushing the PR too 😊

@joshblack joshblack enabled auto-merge (squash) November 27, 2023 22:12
@joshblack joshblack merged commit 20b9445 into main Nov 27, 2023
@joshblack joshblack deleted the ci/update-dependabot-config branch November 27, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants