Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Rails implementation only" copy from IconButton tooltip documentation #927

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

ktravers
Copy link
Contributor

While working on https://github.com/github/github/pull/361769, I noticed that the tooltip functionality described as "Rails only" in the IconButton docs is also in place for the React implementation.

This PR updates the docs accordingly.

Tooltip accessibility features are available in both Rails and React implementations.
Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thank you!

@camertron camertron merged commit ce3c115 into main Feb 11, 2025
6 checks passed
@camertron camertron deleted the ktravers/update-tooltip-docs branch February 11, 2025 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants