Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow status table to render with partial information #882

Merged

Conversation

francinelucca
Copy link
Member

@francinelucca francinelucca commented Oct 25, 2024

Allow status data to render even when partial information is available (i.e. one of the sources fails to load).
See deployment: https://primer-fe30d4f93e-26441320.drafts.github.io/guides/status
Currently it will fail to render and get stuck loading:
image

With fix:
image

Copy link
Contributor

@TylerJDev TylerJDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨ I think loading in partial information is better than none at all, as the table itself provides value.

@francinelucca francinelucca merged commit 8c228a4 into main Oct 28, 2024
7 checks passed
@francinelucca francinelucca deleted the francinelucca/fix/render-status-table-with-incomplete-data branch October 28, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants