Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove /design prefix #645

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Remove /design prefix #645

merged 1 commit into from
Oct 23, 2023

Conversation

camertron
Copy link
Contributor

@camertron camertron commented Oct 20, 2023 •
edited
Loading

Must be shipped in tandem with primer/primer.style#384

(Finally) removes the /design prefix from URLs on primer.style. It's happening.

A scene from the American version of The Office. Boss Michael Scott (Steve Carell) is seen emerging from his office saying "Oh my god! Okay, it's happening!" as his employees scurry for the exits.

Fixes https://github.com/github/primer/issues/2390

@camertron camertron requested a review from a team as a code owner October 20, 2023 18:32
keithamus
keithamus approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

@camertron camertron mentioned this pull request Oct 20, 2023
Merged
@camertron camertron temporarily deployed to github-pages October 23, 2023 18:21 — with GitHub Actions Inactive
@camertron camertron temporarily deployed to github-pages October 23, 2023 18:47 — with GitHub Actions Inactive
@camertron camertron merged commit dba7b8c into main Oct 23, 2023
@camertron camertron deleted the remove_design_prefix branch October 23, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithamus keithamus keithamus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camertron @keithamus